Result type-specific controls in retention rules settings#63
Merged
Conversation
xispa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request improves #62 so the results field from the datagrid in Storage settings is rendered in accordance with the service's Result Type. If the result type is a
selector the like, the system displays a selection list instead of an input text:Current behavior before PR
User has to know the underlying values when configuring the retention period rules for a given service if its result type is a select or the like
Desired behavior after PR is merged
User can directly select the suitable result option with configuring retention period rules for services whose result type is a select or the like
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.