Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fd change allowed version range #16

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

Florian1209
Copy link
Contributor

  • add seadas reader allowed updating range
  • change smos version range

- add seadas reader allowed updating range
- change smos version range
@Florian1209 Florian1209 requested a review from marpet May 27, 2021 12:24
@marpet
Copy link
Member

marpet commented May 27, 2021

But the other properties at the top should be removed.
Otherwise it is not clear which is effective.
And maybe add a comment at the top where to change the version ranges. That one has to scroll down

@Florian1209
Copy link
Contributor Author

It not clear how to works.

"But the other properties at the top should be removed."

Are you talk about these properties?

    <snap.version>8.0.4-SNAPSHOT</snap.version>
    <snap.test.version>8.0.4-SNAPSHOT</snap.test.version>
    <s3tbx.test.version>8.0.4-SNAPSHOT</s3tbx.test.version>
    <s2tbx.test.version>8.0.4-SNAPSHOT</s2tbx.test.version>
    <s1tbx.test.version>8.0.4-SNAPSHOT</s1tbx.test.version>
    <rstb.test.version>8.0.4-SNAPSHOT</rstb.test.version>
    <iceye.test.version>8.0.4-SNAPSHOT</iceye.test.version>
    <seadas-reader.test.version>1.9.4-SNAPSHOT</seadas-reader.test.version>
    <smos.test.version>5.8.1</smos.test.version>

The build failed without these properties

@marpet
Copy link
Member

marpet commented May 27, 2021

Okay. I thought the other properties would replace those at the top. So, then is the question what are the other properties good for?

@Florian1209
Copy link
Contributor Author

@Florian1209
Copy link
Contributor Author

Florian1209 commented May 27, 2021

I'm asking if the reader test causes the gpt test issue" negative offset (I have launched other test this morning, the error still happens in the gpt test after the 8.0.3 release)

@marpet
Copy link
Member

marpet commented May 27, 2021

Puh, this is confusing. So, what is specified in the property at the top is not relevant?
Okay, as long as it works, but better leave a comment that both work together.

Maybe there is something not correct with the dependencies as it was for Oana.

@Florian1209
Copy link
Contributor Author

Otherwise, I try without the maven versions:update-properties.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants