fix: Support 204 response in axios #1428
Open
+49
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopenchi
force-pushed
the
DOCSPLAT-1860
branch
from
a0a0a14 to
600b377
Compare
lopenchi
changed the title
bnb
reviewed
Feb 18, 2025
bnb
reviewed
Mar 24, 2025
| @@ -152,7 +152,7 @@ describe('test_access_settings_whitelist_delete', () => { | |||
| }; | |||
| request.method = 'DELETE'; | |||
| request.url = '/v3/access_settings/whitelist'; | |||
| xit('should have the correct response code', () => { | |||
| it('should have the correct response code', () => { | |||
There was a problem hiding this comment.
In all cases, we should probably also add tests for expected failure state since we are now adding that in (anything that's not 200-299), rather than only the success state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related PR: #1327
fix: Support 204 response in axios
Checklist
If you have questions, please file a support ticket.