(fix) Construct apktool command lines correctly #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Appologies, this is already fixed in #743, but I haven't gotten around to doing final testing on it to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code featured
'-r' if self.skip_resources else ''as an element in the list that was passed tolist2cmdline. This evaluates to a literal empty string ifself.skip_resourcesis false, meaning a literal empty string gets included in the argument list to apktool. For obvious reasons this causes apktool to fail with a command-line syntax error.In this PR I've corrected the logic to actually omit the
-rargument whenself.skip_resourcesis false, and include it otherwise. I also updated the logging so that if there is an error, the user is told the problematic command so that they can run it themselves.There was some trailing whitespace adjacent to my change, so I removed it.