Added an 'ignore' option in bundle config #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
This is a tricky one. SWC has an '--ignore' option, but it allows only a single path to be excluded (or at least I didn't manage to make it take multiple paths.)
So the solution I found was to pass a config snippet with
--config-json(not documented on there website) to override the "exclude" config from.swcrc. This works, but SWC prints an error and exits with a1return code, so I had to disable printing the output of the command (which didn't print anything anyway) and apply a test on the error message to check if it's a 'real' error or just a notification that a file has been skipped.Right now I think it's a very dirty hack, and I don't see any other solution but to ask the swc repo to be able to bypass this