Skip to content

Conversation

TartanLeGrand
Copy link
Contributor

This pull request introduces a significant update to the Sentry Helm charts, primarily focusing on renaming and restructuring components related to "subscription-consumer-results-eap-items" and introducing new configurations for "uptime-results" and "uptime-consumer." The changes aim to improve clarity, consistency, and functionality in deployment configurations.

Renaming and Refactoring Subscription Consumer:

  • The file deployment-sentry-subscription-results-eap-items.yaml was renamed to deployment-sentry-uptime-results.yaml, and all references to subscriptionConsumerResultsEapItems were replaced with uptimeResults in the deployment configuration. This includes updates to fields such as replicas, annotations, podLabels, affinity, nodeSelector, tolerations, volumes, and securityContext. [1] [2] [3] [4] [5]

  • The service account file serviceaccount-sentry-subscription-results-eap-items.yaml was renamed to serviceaccount-sentry-uptime-results.yaml, with corresponding updates to the service account naming and enabling conditions.

Addition of Snuba Uptime Consumer:

  • A new deployment configuration for the Snuba uptime consumer was added in deployment-snuba-uptime-consumer.yaml. This includes support for configurable replicas, environment variables, resource limits, liveness probes, and other deployment settings.

Updates to Values Configuration:

  • In values.yaml, the subscriptionConsumerResultsEapItems section was replaced with uptimeResults, and a new uptimeConsumer section was added under the snuba configuration. These changes introduce default settings for replicas, liveness probes, and other deployment parameters. [1] [2]

@Mokto
Copy link
Contributor

Mokto commented Jul 29, 2025

Could you rename your PR to feat(snuba)!: add uptime consumer deployment configuration

It's a breaking change

@Mokto
Copy link
Contributor

Mokto commented Jul 29, 2025

We also need the documentation on upgrade notes. Thanks!

@TartanLeGrand
Copy link
Contributor Author

Why it's a breaking change ? No migrations have touch, no data loss, no api loss 🤔

@Mokto
Copy link
Contributor

Mokto commented Jul 30, 2025

You've changed the way values are used (and it's much nicer!) so people need to know in case they were using them.

@TartanLeGrand TartanLeGrand force-pushed the feat/add-uptime-consumer branch from d22e51c to 0ae78b8 Compare August 20, 2025 07:55
@Mokto Mokto added the conflicts label Sep 1, 2025
@Mokto
Copy link
Contributor

Mokto commented Sep 1, 2025

👋 Hi, @TartanLeGrand,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants