feat(taskbroker): add deployment #1831
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain why this is needed please? |
|
Taskbroker is a new service that Sentry added in 25.6.0 (as a replacement to Celery), see getsentry/self-hosted#3738. |
|
Wait for getsentry/sentry#96966 because getsentry/self-hosted#3845 |
TartanLeGrand
force-pushed
the
feat/taskbroker
branch
from
920cbf1 to
b700b2a
Compare
|
👋 Hi, @TartanLeGrand, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "taskbroker" component to the Sentry Helm chart, including its deployment, configuration, and associated Kubernetes resources. The changes enable task scheduling and execution capabilities by adding a task broker, task scheduler, and task worker. Additionally, it includes updates to support persistence, autoscaling, and environment-specific configurations.
Taskbroker Component Additions:
Deploymentfor the taskbroker, including support for custom annotations, labels, resource requests/limits, persistence, and environment variables (charts/sentry/templates/sentry/taskbroker/deployment-taskbroker.yaml).Servicefor the taskbroker to facilitate communication on port 50051 (charts/sentry/templates/sentry/taskbroker/service-taskbroker.yaml).charts/sentry/templates/sentry/taskbroker/pvc-taskbroker.yaml).charts/sentry/templates/sentry/taskbroker/hpa-taskbroker.yaml).ServiceAccountfor the taskbroker to manage permissions (charts/sentry/templates/sentry/taskbroker/serviceaccount-sentry-taskbroker.yaml).Task Scheduling Enhancements:
Deploymentfor the task scheduler, which runs thetaskworker-schedulercommand to manage task scheduling (charts/sentry/templates/sentry/taskbroker/deployment-taskscheduler.yaml).Deploymentfor task workers to execute tasks, including support for concurrency and RPC communication with the taskbroker (charts/sentry/templates/sentry/taskbroker/deployment-taskworker.yaml).Configuration Updates:
charts/sentry/templates/_helper.tpl). [1] [2]charts/sentry/templates/_helper.tpl).Values Configuration:
taskbrokersection invalues.yamlfor configuring replicas, autoscaling, persistence, resource requests/limits, and environment variables (charts/sentry/values.yaml). [1] [2]These changes collectively enhance the Sentry Helm chart by introducing a robust task management system and providing flexibility for deployment configurations.