Skip to content

Fix recursion depth limit when hashing numpy.datetime64 #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Fix recursion depth limit when hashing numpy.datetime64 #537

merged 1 commit into from
May 4, 2025

Conversation

jcipar
Copy link
Contributor

@jcipar jcipar commented Mar 29, 2025

This fixes the bug described in issue 534.

Adds np.datetime64 to:

  • helper.numpy_dtypes
  • helper.datetimes
  • helper.times

It adds tests to test_numpy_diff and to test_hash checking equal and unequal datetime64.

@jcipar
Fix recursion depth limit when hashing numpy.datetime64
ed57957 
This fixes the bug described in [issue 534](seperman#534).
seperman
seperman approved these changes May 4, 2025
View reviewed changes
Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcipar
Thanks for making the PR! LGTM!

@seperman seperman merged commit 901eeff into seperman:dev May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seperman seperman seperman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcipar @seperman