fix: fixes a regex problem on groundswell manifest

[justinegeffen]

Recreating PR https://github.com/seqeralabs/docs_old/pull/115

[netlify]

✅ Deploy Preview for seqera-docs ready!

Name	Link
🔨 Latest commit	a77a645
🔍 Latest deploy log	https://app.netlify.com/sites/seqera-docs/deploys/670e7c55c13a060009a433e0
😎 Deploy Preview	https://deploy-preview-9--seqera-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[justinegeffen]

@gwright99, please review this when you have a chance. Thank you!

[gwright99]

I'm a bit foggy on this issue (looking at original ticket now - I remember the issue, I just don't remember exactly how to test) -- any suggestions on how your folks tested it?

[justinegeffen]

@bebosudo, would you be open to reviewing this? Thank you!

[justinegeffen]

I'm a bit foggy on this issue (looking at original ticket now - I remember the issue, I just don't remember exactly how to test) -- any suggestions on how your folks tested it?

I've added @bebosudo to this issue for that feedback as I believe he tested it. :)

[bebosudo]

Unfortunately the proposed fix doesn't work when the tower db url contains extra parameters (like 99% of the cases) and only works with a db url without parameters like for the customer who pointed it out (see also this?), as I showed in this message:

[alberto@fedora]$ podman run --rm -it  --entrypoint bash mysql:5.7
bash-4.2#
bash-4.2# TOWER_DB_URL="jdbc:mysql://tower.cluster-c1rjv6umdpvw.eu-west-2.rds.amazonaws.com:3306/tower?&usePipelineAuth=false&useBatchMultiSend=false"
bash-4.2# mysqlsh --uri "$(echo $TOWER_DB_URL |sed -e 's@jdbc:\(.*\)@\1@')"
Invalid URI: Invalid connection option ''.

bash-4.2# TOWER_DB_URL="jdbc:mysql://tower.cluster-c1rjv6umdpvw.eu-west-2.rds.amazonaws.com:3306/tower"
bash-4.2# mysqlsh --uri "$(echo $TOWER_DB_URL |sed -e 's@jdbc:\(.*\)@\1@')"
Please provide the password for '[email protected]:3306': 

That's because mysqlsh doesn't accept extra parameters.

I proposed a fix that should work for both cases, your feedback would be appreciated @swampie @gwright99

bash-4.2# TOWER_DB_URL="jdbc:mysql://tower.cluster-c1rjv6umdpvw.eu-west-2.rds.amazonaws.com:3306/tower?&usePipelineAuth=false&useBatchMultiSend=false" 
bash-4.2# mysqlsh --uri "$(echo $TOWER_DB_URL |cut -d'?' -f1 |sed -e 's@jdbc:\(.*\)@\1@')"
Please provide the password for '[email protected]:3306':

bash-4.2# TOWER_DB_URL="jdbc:mysql://tower.cluster-c1rjv6umdpvw.eu-west-2.rds.amazonaws.com:3306/tower"
bash-4.2# mysqlsh --uri "$(echo $TOWER_DB_URL |cut -d'?' -f1 |sed -e 's@jdbc:\(.*\)@\1@')"
Please provide the password for '[email protected]:3306': 

[gwright99]

Given the recent addition of a mandatory connection string modifier for v24.1+ (and all the various connection string modifiers that need to be used for various DB products < 24.1), I think we need to scrap the old way and go with @bebosudo's new approach.

[justinegeffen]

Thanks, @bebosudo! Much appreciated. @gwright99, please review/approve when you have a chance. Thank you!

Changes have been implemented

[justinegeffen]

@bebosudo, following up on this for approval. Thank you! :)

[bebosudo]

the regex looks correct now, I didn't test it

non-blocking: left some comments about possible improvements we could do, don't know if you prefer to follow up in a separate PR, up to you

[justinegeffen]

Thanks, @bebosudo! I updated this for 24.1 as well.