Implement Deserializer for Map<String, Value> and &Map<String, Value>
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can now be replaced with a direct call to the Deserializer impl on Map (or &Map, as applicable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Deserializerimpls forMap<String, Value>and&Map<String, Value>andIntoDeserializerimpls for the same. The first commit moves the relevant code from the valueDeserializerimpl into the new map impls. The last two are some small cleanups to use the map deserializer impl directly.I put the
Deserializertrait impls insrc/value/de.rsso that they can reuse the existing helpers there. If you would prefer that they go elsewhere I am happy to move them.Closes #1134