Added Downloadable Windows Script #626
Conversation
Added downloadable 'Send to' Windows Context Menu script as requested in sergix44#580 . All .bat code provided by https://github.com/Sectly Preview: https://senkawolf.fyi/me/RUgOWoQI51.png
|
Very nice hope it gets added to release as soon as possible 😄 |
| $fileName = $fileBaseName . '.bat'; // Full file name with extension | ||
|
|
||
| // Prepare the content of the .txt file | ||
| $batscript = '@echo off' . PHP_EOL; |
There was a problem hiding this comment.
🔨 issue: Can you please put the script in a proper template like for the others? This is very hard to understand and maintain
| $batscript .= ':CreateSendToShortcut' . PHP_EOL; | ||
| $batscript .= 'set "ShortcutName=Upload to ' .$appName. ' (@'.$user->username.').lnk"' . PHP_EOL; | ||
| $batscript .= 'set "ShortcutPath=%APPDATA%\\Microsoft\\Windows\\SendTo\\%ShortcutName%"' . PHP_EOL; | ||
| $batscript .= 'set "IconUrl=https://xbackbone.app/favicon.ico"' . PHP_EOL; |
There was a problem hiding this comment.
🔨 issue: This shuld point to the current instance, not the xbb website.
| $config = include __DIR__ . '/../../config.php'; // Adjust the path as necessary | ||
| $appName = $config['app_name'] ?? 'XBackBone'; // Provide a default if not set |
There was a problem hiding this comment.
🔨 issue: config must be fetch from the container, as it can be altered during bootstrapping. The config file is never read during the app runtime
|
You can use my contribution I made a year ago as an guide and example to fix for all these issues Sergi mentioned. Sorry if it is a little hard to read, it is a limitation with how KDE handles shell commands. Found here: #554. Good luck :) |
Added downloadable 'Send to' Windows Context Menu script as requested in #580 . All .bat code provided by https://github.com/Sectly
Preview: https://senkawolf.fyi/me/RUgOWoQI51.png