fix: avert crashes from missing package.json#3064
Closed
rotu wants to merge 1 commit into
Closed
Conversation
Previously `npx @serialport/list` and `npx @serialport/terminal` would crash as they would search the local filesystem for package.json to find the version. Now these tools print the correct version.
rotu
changed the title
Member
|
Thank you! I'm going with the approach in #3070 as it uses import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
npx @serialport/listandnpx @serialport/terminalwould crash as they would search the local filesystem for package.json to find the version. Now these tools print the correct version.Fixes #2972