Patch - #48
Merged
Merged
Conversation
* This Makefile is the boiler-plate Makefile that I use for all
my projects.
- fmt: uses air to format R code.
* The Air-formatter skips the files that hast \dontrun{} or other roxygen
controls. Consider submitting a issue upstream.
* The command cleans up build artifacts from R CMD build and R CMD check * Updated .Rbuildignore to include Makefile
* The documentation has been updated to accompany the Air formatter.
- The examples got reformatted, and this affects the examples too.
* The bug consisted of parsing and returning the incorrect column.
- It was returning the time-index instead of the rate.
* The Makefile contained calls to non-existing files (from other projects)
* The CMC intervals are now streamlined so it shows months instead of days
* The infer_intervals have been adjusted accordingly
- There should be a more robust approach to this...
* Refined *some* of the code, and added CoinMarketCap
* The rendered sample output were acting up on CRAN machines.
- The reason: chart.html:140:1 (chart.Rd:36): Warning: missing </span> before <p>
Its unclear why this throws an error now. This is not something that I could reproduce locally.
In any case the sample output is now moved --- there is no need to chase it around as it is going
to be removed from {cryptoQuotes} anyways.
* The Makefile now includes rendering the NEWS.Rmd
* Added entries for the fixes
* There is bug somewhere that breaks {plotly} so it cant be screenshotted properly. This is most likely related to my own machine.
* Needed links to the {xts}-library
* Version 1.3.3 has been submitted to CRAN. Waiting on acceptance before merging.
* The screenshots from {plotly} now works as expected.
* The Makefile now builds and previews {pkgdown}
* NOTE: This was not exported to CRAN. This is what happens when you do too many things at the same time...
serkor1
marked this pull request as ready for review
September 18, 2025 05:24
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to ba5bb89 in 4 minutes and 26 seconds. Click for details.
- Reviewed
11566lines of code in103files - Skipped
10files when reviewing. - Skipped posting
96draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tests/testthat/test-getFNG.R:22
- Draft comment:
The comment says 'check that it returns 100 rows' but the expectation is for 200 rows. Please update the comment to match the expected value. - Reason this comment was not posted:
Comment was on unchanged code.
2. NEWS.md:31
- Draft comment:
Typo/grammar note: In the bugfix section, the sentence "A bug in the funding rates from Binance have been fixed." should be updated for subject-verb agreement (e.g. "A bug in the funding rates from Binance has been fixed."). Also, in the following sentence, "The returned values was the time indices..." should use "were" instead of "was." - Reason this comment was not posted:
Marked as duplicate.
3. NEWS.md:378
- Draft comment:
Typo detected: The line 'L378:)' appears to contain an unexpected ')'. Please verify if this is intentional or if it should be removed or corrected. - Reason this comment was not posted:
Comment was on unchanged code.
4. R/api_binance.R:219
- Draft comment:
Typographical error: The key 'colum_names' appears to be misspelled. It likely should be 'column_names'. This issue appears in several blocks (e.g., line 219, 227, and 235), so please update for consistency. Similarly, 'colum_location' on lines 221 and 237 may also be a typo (likely 'column_location'). - Reason this comment was not posted:
Comment was on unchanged code.
5. R/api_bybit.R:139
- Draft comment:
Typographical error: The key 'colum_location' appears to be misspelled. It should likely be 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
6. R/api_bybit.R:155
- Draft comment:
Typographical error: The variable name 'colum_names' appears to be misspelled. It is likely meant to be 'column_names'. - Reason this comment was not posted:
Comment was on unchanged code.
7. R/api_bybit.R:157
- Draft comment:
Typographical error: The variable name 'colum_location' appears to be misspelled. It is likely meant to be 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
8. R/api_bybit.R:163
- Draft comment:
Typo: 'colum_names' appears to be misspelled. Should it be 'column_names'? - Reason this comment was not posted:
Comment was on unchanged code.
9. R/api_bybit.R:165
- Draft comment:
Typo: 'colum_location' appears to be misspelled. Consider replacing it with 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
10. R/api_bybit.R:188
- Draft comment:
Typo in comment: 'determine wether' should be corrected to 'determine whether'. - Reason this comment was not posted:
Comment was on unchanged code.
11. R/api_cmc.R:130
- Draft comment:
Typo: The comment uses "wether" instead of "whether". Please correct it. - Reason this comment was not posted:
Comment was on unchanged code.
12. R/api_cmc.R:131
- Draft comment:
Typo: Consider changing "its" to "it's" in the comment for correct grammar. - Reason this comment was not posted:
Comment was on unchanged code.
13. R/api_cryptocom.R:125
- Draft comment:
Possible Typo: 'colum_location' might be intended to be 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
14. R/api_cryptocom.R:149
- Draft comment:
Typo: In the comment "# 1) if its a response", consider using "if it's a response" (adding an apostrophe) for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
15. R/api_huobi.R:125
- Draft comment:
Typo: "colum_names" is likely a misspelling. It should be "column_names". - Reason this comment was not posted:
Comment was on unchanged code.
16. R/api_huobi.R:142
- Draft comment:
Typo: Consider renaming 'colum_location' to 'column_location' if that is the intended variable name. - Reason this comment was not posted:
Comment was on unchanged code.
17. R/api_huobi.R:161
- Draft comment:
Typo: In the comment, 'wether' should be spelled as 'whether'. - Reason this comment was not posted:
Comment was on unchanged code.
18. R/api_huobi.R:162
- Draft comment:
Typo: In the comment, 'its a response or request' should likely be 'it's a response or request'. - Reason this comment was not posted:
Comment was on unchanged code.
19. R/api_kraken.R:151
- Draft comment:
Typo: The key 'colum_names' appears to be misspelled. It should likely be 'column_names'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
20. R/api_kraken.R:186
- Draft comment:
Typographical error: 'colum_names' appears to be a misspelling. Consider changing it to 'column_names'. - Reason this comment was not posted:
Comment was on unchanged code.
21. R/api_kraken.R:188
- Draft comment:
Typographical error: 'colum_location' appears to be a misspelling. Consider changing it to 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
22. R/api_kraken.R:194
- Draft comment:
Typographical error: 'colum_names' appears to be a misspelling. Consider changing it to 'column_names'. - Reason this comment was not posted:
Comment was on unchanged code.
23. R/api_kraken.R:196
- Draft comment:
Typographical error: 'colum_location' appears to be a misspelling. Consider changing it to 'column_location'. - Reason this comment was not posted:
Comment was on unchanged code.
24. R/api_kucoin.R:149
- Draft comment:
Typo: It looks like "colum_names" might be intended to be "column_names". - Reason this comment was not posted:
Comment was on unchanged code.
25. R/api_kucoin.R:161
- Draft comment:
Typo: It looks like "colum_location" might be intended to be "column_location". - Reason this comment was not posted:
Comment was on unchanged code.
26. R/api_mexc.R:148
- Draft comment:
Typographical error: The key 'colum_names' appears to be misspelled. It likely should be 'column_names'. If intentional, please disregard. - Reason this comment was not posted:
Comment was on unchanged code.
27. R/api_mexc.R:150
- Draft comment:
Typographical error: The key 'colum_location' appears to be misspelled. It likely should be 'column_location'. If this is intentional, please ignore. - Reason this comment was not posted:
Comment was on unchanged code.
28. R/available_exchanges.R:105
- Draft comment:
Typo: 'retun' should be 'return' in the comment on line 105. - Reason this comment was not posted:
Comment was on unchanged code.
29. R/chart.R:173
- Draft comment:
Typo: The word "interactivitiy" appears to be misspelled. Consider replacing it with "interactivity". - Reason this comment was not posted:
Comment was on unchanged code.
30. R/chart_ma.R:286
- Draft comment:
Typo alert: In the comment "# too in the naming.", 'too' might be a typo. Consider revising to "also in the naming" or clarifying the intended message. - Reason this comment was not posted:
Comment was on unchanged code.
31. R/get_fundingrate.R:103
- Draft comment:
The comment reads "# it seems that all exchanges uses". Consider changing "uses" to "use" for grammatical correctness. - Reason this comment was not posted:
Comment was on unchanged code.
32. R/helper.R:152
- Draft comment:
Typo found: The comment says "create a trable" which should be corrected to "create a table". - Reason this comment was not posted:
Comment was on unchanged code.
33. R/helper.R:619
- Draft comment:
There's a typographical error in the comment: "passed futher;" should be "passed further;". - Reason this comment was not posted:
Comment was on unchanged code.
34. R/helper.R:702
- Draft comment:
Typographical error: 'extracing' should be 'extracting'. - Reason this comment was not posted:
Comment was on unchanged code.
35. R/utils.R:21
- Draft comment:
Typo: 'crated' should be 'created' in the return description. - Reason this comment was not posted:
Comment was on unchanged code.
36. man/alma.Rd:17
- Draft comment:
Typo detected: 'to passed into' should be changed to 'to be passed into'. - Reason this comment was not posted:
Comment was on unchanged code.
37. man/bollinger_bands.Rd:33
- Draft comment:
The link text and alias for the plotly wrapper function appear inconsistent. The link alias is set toplotly:add_tracebut the visible text isplotly::add_lines(). Please ensure that both the link alias and displayed function name match. - Reason this comment was not posted:
Marked as duplicate.
38. man/bollinger_bands.Rd:34
- Draft comment:
Similarly, for the TTR function the link alias isTTR:bollingerBandswhile the displayed text isTTR::BBands(). Consider updating these for consistency. - Reason this comment was not posted:
Comment looked like it was already resolved.
39. man/calibrate_window.Rd:69
- Draft comment:
Typographical Issue: In the comment on line 69, "check if candles aligns" appears to have subject-verb agreement error. Consider changing "aligns" to "align" (i.e., "check if candles align") for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
40. man/chart.Rd:24
- Draft comment:
Typographical/lexicographical inconsistency in the 'indicator' item: the link reference isplotly:add_tracebut the displayed function isplotly::add_lines(). Please update one so they match. - Reason this comment was not posted:
Marked as duplicate.
41. man/dema.Rd:18
- Draft comment:
Typo on line 18: The phrase "to passed" appears to be incorrect. It should likely be corrected to "to pass" (or "to be passed") to ensure proper grammar. - Reason this comment was not posted:
Comment was on unchanged code.
42. man/dema.Rd:39
- Draft comment:
The new diff changes the link target fromplotly:add_linestoplotly:add_trace, but the displayed function remainsplotly::add_lines(). This inconsistency may be confusing, so please verify which function is intended and update the display text accordingly. - Reason this comment was not posted:
Marked as duplicate.
43. man/donchian_channel.Rd:31
- Draft comment:
Typographical inconsistency: The link's label has been changed to "plotly:add_trace", but the displayed function name remains "plotly::add_lines()". This could be confusing for the user. Please update one or the other to ensure consistency. - Reason this comment was not posted:
Marked as duplicate.
44. man/ema.Rd:17
- Draft comment:
Typo: Consider changing "to passed" to "to be passed" in the description. - Reason this comment was not posted:
Comment was on unchanged code.
45. man/ema.Rd:36
- Draft comment:
Typographical Issue: The link text references an inconsistent function name. The link target is set to plotly:add_trace, but the displayed text is plotly::add_lines(). Please verify which function should be correctly referenced and update the code accordingly. - Reason this comment was not posted:
Marked as duplicate.
46. man/evwma.Rd:15
- Draft comment:
Typographical Error: The phrase "to passed" appears to be missing the word "be". Consider changing it to "The name of the vector to be passed" for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
47. man/evwma.Rd:28
- Draft comment:
The change on this line has a potential inconsistency: the link now targetsplotly:add_trace, yet the displayed function name is stillplotly::add_lines(). Please verify if the display text should also be updated toplotly::add_trace()or if the link target needs to revert. - Reason this comment was not posted:
Marked as duplicate.
48. man/examples/scr_addEvents.R:69
- Draft comment:
Typographical error: the comment contains 'Chart the the klines'. Consider correcting it to 'Chart the klines'. - Reason this comment was not posted:
Comment was on unchanged code.
49. man/get_mktcap.Rd:43
- Draft comment:
Typo: The use of\verb{from``` appears incorrect due to the extra backticks. It likely should be\verb{from}` to properly format the code. - Reason this comment was not posted:
Marked as duplicate.
50. man/get_mktcap.Rd:43
- Draft comment:
Typo: There is an unexpected closing brace after "either" (i.e.either}) that seems to be a mistake. Consider removing it to ensure the formatting is correct. - Reason this comment was not posted:
Comment looked like it was already resolved.
51. man/get_openinterest.Rd:58
- Draft comment:
There appears to be a typographical error in the use of the \verb command. The textfrom`` seems to include extraneous backticks and the syntax around the 'from' and 'to' elements is broken (e.g.\verb{from`` or }to\verb{must be coercible...). It likely should properly enclose each element (e.g.\verb{from}` and `\verb{to}`) and use consistent notation for the date functions. Please review and correct the formatting. - Reason this comment was not posted:
Marked as duplicate.
52. man/get_quote.Rd:66
- Draft comment:
There are several typos in this line related to the use of verbatim formatting: • The text\verb{from`` or }to\verb{mustappears to have mismatched delimiters. It seems the intent was to mark both "from" and "to" as verbatim, for example:\verb{from}or\verb{to}. • Additionally, the format strings are enclosed inconsistently. Consider revising the line for clarity, e.g., "Values passed to \verb{from} or \verb{to} must be coercible by \code{\link[=as.Date]{as.Date()}} or \code{\link[=as.POSIXct]{as.POSIXct()}}, with a format of either \sQuote{%Y-%m-%d} or \sQuote{%Y-%m-%d %H:%M:%S}." Please fix these issues before merging. - Reason this comment was not posted:
Marked as duplicate.
53. man/hma.Rd:15
- Draft comment:
Typographical error: It looks like "to passed" should be "to be passed" for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
54. man/hma.Rd:28
- Draft comment:
Typo: The link target is set toplotly:add_tracewhile the displayed function name isplotly::add_lines(). Please verify which function should be referenced to avoid confusion. - Reason this comment was not posted:
Marked as duplicate.
55. man/macd.Rd:43
- Draft comment:
Typographical error: The displayed function name in the link text still readsplotly::add_lines()even though the link now refers toplotly:add_trace. Please update the displayed name to match the correct function (likelyplotly::add_trace()). - Reason this comment was not posted:
Marked as duplicate.
56. man/rsi.Rd:46
- Draft comment:
There's an inconsistency in the function reference on this line. The link target is usingplotly:add_trace, but the displayed text still showsplotly::add_lines(). This appears to be a typographical error that should be corrected for clarity. - Reason this comment was not posted:
Marked as duplicate.
57. man/sma.Rd:15
- Draft comment:
Typographical error: The phrase "to passed into" should likely be "to be passed into". - Reason this comment was not posted:
Comment was on unchanged code.
58. man/sma.Rd:28
- Draft comment:
Typographical inconsistency: The link anchor is updated toplotly:add_tracebut the displayed function name remainsplotly::add_lines(). Please verify if this is intentional or if the displayed text should be updated to match the new anchor. - Reason this comment was not posted:
Marked as duplicate.
59. man/smi.Rd:45
- Draft comment:
Typo: The link text still shows "TTR::SMI" even though the package reference has been updated to "TTR:stochastics". Please verify if this was intended; if not, update the display text to match. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =50%<= threshold50%The comment points out a typo in the link text, which is a valid concern. However, it also asks the author to verify if this was intended, which violates the rules. The useful part of the comment is the identification of the typo.
60. man/smi.Rd:60
- Draft comment:
Typographical inconsistency: The link target isplotly:add_tracebut the displayed function isplotly::add_lines(). Please correct this mismatch so that the link target and the displayed function are consistent. - Reason this comment was not posted:
Marked as duplicate.
61. man/smi.Rd:61
- Draft comment:
Typographical inconsistency: The link usesTTR:stochasticswhile the function call isTTR::SMI(). Consider updating the link or the displayed function name to match correctly. - Reason this comment was not posted:
Comment looked like it was already resolved.
62. man/vwap.Rd:16
- Draft comment:
There's a typographical error: the phrase "to passed into" should be corrected to "to be passed into". - Reason this comment was not posted:
Comment was on unchanged code.
63. man/vwap.Rd:32
- Draft comment:
There appears to be an inconsistency on line 32: the link reference now usesplotly:add_tracewhile the displayed text remainsplotly::add_lines(). Please verify if this is intentional or if it should be aligned. - Reason this comment was not posted:
Marked as duplicate.
64. man/wma.Rd:16
- Draft comment:
Typographical error: consider changing 'to passed' to 'to be passed'. - Reason this comment was not posted:
Comment was on unchanged code.
65. man/wma.Rd:32
- Draft comment:
The function link now targetsplotly:add_trace, but the displayed function name remainsplotly::add_lines(). Please ensure that both the link target and the display text match (i.e., either useadd_tracefor both, or maintainadd_linesfor both) to avoid confusion. - Reason this comment was not posted:
Marked as duplicate.
66. man/write_xts.Rd:43
- Draft comment:
Typographical note: The sentence "the \link{attributes} does not follow the object" contains a subject-verb agreement issue. Since "attributes" is plural, it should read "do not follow the object." - Reason this comment was not posted:
Comment was on unchanged code.
67. man/zlema.Rd:16
- Draft comment:
Typographical error: "to passed" seems incorrect. Consider replacing with "to be passed" or "to pass" for improved clarity. - Reason this comment was not posted:
Comment was on unchanged code.
68. man/zlema.Rd:32
- Draft comment:
The wrapper function text currently reads "plotly::add_lines()" while the link is updated to use "plotly:add_trace". This mismatch is likely unintentional. Please update the function name and link target to be consistent (either both should reference add_trace or add_lines) before merging. - Reason this comment was not posted:
Marked as duplicate.
69. tests/testthat/test-CICD.R:52
- Draft comment:
Typo: The comment says "wether"; it should read "whether". - Reason this comment was not posted:
Comment was on unchanged code.
70. tests/testthat/test-CICD.R:115
- Draft comment:
Typo: The comment says "wether"; it should read "whether". - Reason this comment was not posted:
Comment was on unchanged code.
71. tests/testthat/test-FGIndex.R:9
- Draft comment:
Typographical error: In the test description, "correcty" should be spelled "correctly". - Reason this comment was not posted:
Comment was on unchanged code.
72. tests/testthat/test-FUN.R:10
- Draft comment:
Typo: "convincience" should be "convenience" in this comment. - Reason this comment was not posted:
Comment was on unchanged code.
73. tests/testthat/test-FUN.R:27
- Draft comment:
Grammatical issue: the comment "it needs to passed into calibrateWindow" should be "it needs to be passed into calibrateWindow". - Reason this comment was not posted:
Comment was on unchanged code.
74. tests/testthat/test-availableTickers.R:17
- Draft comment:
Typo in comment: "wether" should be "whether". - Reason this comment was not posted:
Comment was on unchanged code.
75. tests/testthat/test-availableTickers.R:50
- Draft comment:
Typo in comment: "wether" should be "whether". - Reason this comment was not posted:
Comment was on unchanged code.
76. tests/testthat/test-availableTickers.R:83
- Draft comment:
Typo in comment: "wether" should be "whether". - Reason this comment was not posted:
Comment was on unchanged code.
77. tests/testthat/test-availableTickers.R:116
- Draft comment:
Typo in comment: "wether" should be "whether". - Reason this comment was not posted:
Comment was on unchanged code.
78. tests/testthat/test-charting.R:4
- Draft comment:
Typo: 'wether' should be 'whether'. - Reason this comment was not posted:
Comment was on unchanged code.
79. tests/testthat/test-charting.R:37
- Draft comment:
Typo: 'erros' should be 'errors'. - Reason this comment was not posted:
Comment was on unchanged code.
80. tests/testthat/test-charting.R:42
- Draft comment:
Typo in comment: 'its a plotly' should be "it's a plotly". - Reason this comment was not posted:
Comment was on unchanged code.
81. tests/testthat/test-charting.R:83
- Draft comment:
Typo: 'erros' should be 'errors'. - Reason this comment was not posted:
Comment was on unchanged code.
82. tests/testthat/test-charting.R:88
- Draft comment:
Typo in comment: 'its a plotly' should be "it's a plotly". - Reason this comment was not posted:
Comment was on unchanged code.
83. tests/testthat/test-charting.R:129
- Draft comment:
Typo: 'erros' should be 'errors'. - Reason this comment was not posted:
Comment was on unchanged code.
84. tests/testthat/test-charting.R:174
- Draft comment:
Typo: 'lenght.out' should be 'length.out'. - Reason this comment was not posted:
Comment was on unchanged code.
85. tests/testthat/test-getFNG.R:2
- Draft comment:
The comment on this line says "skip if online" but the function call isskip_if_offline(). Consider updating the comment to match the function behavior. - Reason this comment was not posted:
Comment was on unchanged code.
86. tests/testthat/test-getFNG.R:13
- Draft comment:
Minor typographical issue: The comment reads "test that its an". It might be clearer as "test that it's an" or "test that it is an". - Reason this comment was not posted:
Comment was on unchanged code.
87. tests/testthat/test-getFNG.R:23
- Draft comment:
The comment here indicates that 100 rows are expected, but the test asserts that 200 rows are expected. Please update the comment to accurately reflect the expected output. - Reason this comment was not posted:
Comment was on unchanged code.
88. tests/testthat/test-getFundingrate.R:38
- Draft comment:
Typo: Consider changing "yesterdays date" to "yesterday's date". - Reason this comment was not posted:
Comment was on unchanged code.
89. tests/testthat/test-getFundingrate.R:40
- Draft comment:
Typo: "non-realiszed values" should likely be "non-realized values". - Reason this comment was not posted:
Comment was on unchanged code.
90. tests/testthat/test-getLSRatio.R:10
- Draft comment:
Typo in comment: 'exchnages' should be 'exchanges'. - Reason this comment was not posted:
Comment was on unchanged code.
91. tests/testthat/test-getLSRatio.R:73
- Draft comment:
Typo in comment: 'minium' should be 'minimum'. - Reason this comment was not posted:
Comment was on unchanged code.
92. tests/testthat/test-getQuote.R:103
- Draft comment:
Typo detected: "wether" should be corrected to "whether". - Reason this comment was not posted:
Comment was on unchanged code.
93. tests/testthat/test-globalmktcap.R:19
- Draft comment:
Typographical note: the comment "its a xts-object" might be reworded to include the missing apostrophe and correct the article usage (e.g. "it's an xts-object") for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
94. tests/testthat/test-infer_interval.R:10
- Draft comment:
Typo: In the description text, "All inferred intervals corresponds" should be "All inferred intervals correspond" to match the plural subject. - Reason this comment was not posted:
Comment was on unchanged code.
95. tests/testthat/test-is-date.R:26
- Draft comment:
Typographical error: In the comment, "POSITXct" should be "POSIXct". - Reason this comment was not posted:
Comment was on unchanged code.
96. tests/testthat/test-store_xts.R:22
- Draft comment:
Typo: In the comment "# 2) check if its equal", consider using "if it's equal" for correct grammar. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_WghWXKxNPC9e2yIP
You can customize 
| @Rscript -e "pkgdown::init_site()" | ||
| @Rscript -e "pkgdown::build_site()" | ||
|
|
||
| pkgdown-preview: ## Preview {pkgdown} documetation |
There was a problem hiding this comment.
Typo detected: the word "documetation" should be "documentation" in the comment for the pkgdown-preview target.
Suggested change
| pkgdown-preview: ## Preview {pkgdown} documetation | |
| pkgdown-preview: ## Preview {pkgdown} documentation |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
|
|
||
| ## Bugfixes | ||
|
|
||
| * A bug in the funding rates from Binance have been fixed. The returned values was the time indices of the json-array, not the actual rates. |
There was a problem hiding this comment.
Typo/grammar suggestion: In this line, consider revising the sentence to: "A bug in the funding rates from Binance has been fixed. The returned values were the time indices of the JSON array, not the actual rates." This will improve clarity and consistency.
Suggested change
| * A bug in the funding rates from Binance have been fixed. The returned values was the time indices of the json-array, not the actual rates. | |
| * A bug in the funding rates from Binance has been fixed. The returned values were the time indices of the JSON array, not the actual rates. |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| fundingrate = { | ||
| list( | ||
| colum_names = "funding_rate", | ||
| colum_names = "funding_rate", |
There was a problem hiding this comment.
Possible Typo: 'colum_names' might be intended to be 'column_names'.
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| "1296000" = "15d", | ||
| "604800" = "1w", | ||
| "1209600" = "2w", | ||
| "1296000" = "2w", |
There was a problem hiding this comment.
There is a duplicate case for the key "1296000" (lines 219 and 222); one mapping is "15d" and the other is "2w". This appears to be a typographical oversight. Please verify and correct one of these mappings.
Suggested change
| "1296000" = "2w", |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| \ifelse{html}{\href{https://lifecycle.r-lib.org/articles/stages.html#experimental}{\figure{lifecycle-experimental.svg}{options: alt='[Experimental]'}}}{\strong{[Experimental]}} | ||
|
|
||
| A high-level \code{\link[plotly:add_lines]{plotly::add_lines()}}-wrapper function that | ||
| A high-level \code{\link[plotly:add_trace]{plotly::add_lines()}}-wrapper function that |
There was a problem hiding this comment.
Typographical inconsistency: The Rd file now uses \code{\link[plotly:add_trace]{plotly::add_lines()}} where the hyperlink target is 'plotly:add_trace' but the displayed function name remains 'plotly::add_lines()'. Please verify if this is intentional, or if the displayed text should be updated to match the target.
Suggested change
| A high-level \code{\link[plotly:add_trace]{plotly::add_lines()}}-wrapper function that | |
| A high-level \code{\link[plotly:add_trace]{plotly::add_trace()}}-wrapper function that |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
|
|
||
| \item{lower_limit}{A \link{numeric}-vector of \link{length} 1. -40 by default. | ||
| Sets the lower limit of the \link[TTR:SMI]{TTR::SMI}.} | ||
| Sets the lower limit of the \link[TTR:stochastics]{TTR::SMI}.} |
There was a problem hiding this comment.
Typo: The link text remains "TTR::SMI" while the package link now points to "TTR:stochastics". Consider updating the displayed text for consistency.
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| \ifelse{html}{\href{https://lifecycle.r-lib.org/articles/stages.html#experimental}{\figure{lifecycle-experimental.svg}{options: alt='[Experimental]'}}}{\strong{[Experimental]}} | ||
|
|
||
| The \code{\link[=write_xts]{write_xts()}}- and \code{\link[=read_xts]{read_xts()}}-functions are \code{\link[zoo:write.zoo]{zoo::write.zoo()}}- and \code{\link[zoo:read.zoo]{zoo::read.zoo()}}-wrapper functions. | ||
| The \code{\link[=write_xts]{write_xts()}}- and \code{\link[=read_xts]{read_xts()}}-functions are \code{\link[zoo:read.zoo]{zoo::write.zoo()}}- and \code{\link[zoo:read.zoo]{zoo::read.zoo()}}-wrapper functions. |
There was a problem hiding this comment.
Typo alert: The link for the write method appears to be incorrect. It currently uses \link[zoo:read.zoo]{zoo::write.zoo()}, but it likely should be \link[zoo:write.zoo]{zoo::write.zoo()}.
Suggested change
| The \code{\link[=write_xts]{write_xts()}}- and \code{\link[=read_xts]{read_xts()}}-functions are \code{\link[zoo:read.zoo]{zoo::write.zoo()}}- and \code{\link[zoo:read.zoo]{zoo::read.zoo()}}-wrapper functions. | |
| The \code{\link[=write_xts]{write_xts()}}- and \code{\link[=read_xts]{read_xts()}}-functions are \code{\link[zoo:write.zoo]{zoo::write.zoo()}}- and \code{\link[zoo:read.zoo]{zoo::read.zoo()}}-wrapper functions. |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| ) | ||
| }) | ||
|
|
||
| # 2) Long-Short Ration |
There was a problem hiding this comment.
Typo: The comment "Long-Short Ration" should be corrected to "Long-Short Ratio".
Suggested change
| # 2) Long-Short Ration | |
| # 2) Long-Short Ratio |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| testthat::expect_equal( | ||
| zoo::index(BTC), | ||
| zoo::index(FGIndex) | ||
| testthat::test_that(desc = "Test that the convinience functions calibrates the data correctly", code = { |
There was a problem hiding this comment.
Typo: "convinience" should be "convenience" in the test description.
Suggested change
| testthat::test_that(desc = "Test that the convinience functions calibrates the data correctly", code = { | |
| testthat::test_that(desc = "Test that the convenience functions calibrates the data correctly", code = { |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
| event_data$Close | ||
| ) | ||
|
|
||
| # 2) Chart the the klines |
There was a problem hiding this comment.
Typo in comment: 'Chart the the klines' contains a duplicate 'the'. Consider revising to 'Chart the klines'.
Suggested change
| # 2) Chart the the klines | |
| # 2) Chart the klines |
This comment was generated because it violated a code review rule: mrule_DAckc2vbWZgKkigK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
This PR consists of two bug-fixes --- one user-reported, and one reported by CRAN:
Funding Ratefrom Binance API were returning vectors of dates instead of the Funding Rate. Thank you Michael; I would have put your name in the release docs but I do not have your Github-handle.Repository and pkg-specific changes
1Minstead of30d.Note
See commit history for more details.