Check channel address when receiving payment in CLI #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an IOU is received its signature covers a channel address. There are two possible ways to proceed: 1. Take this address and apply the IOU to the channel with this addres. 2. Ask the receiving user to provide the address of the channel that this IOU has been received from. Had we gone with option 1, we would not have this issue. But we chose option 2, ironically, as an extra precaution: by explicitly giving the address of the channel “through” which the IOU was received, the user explicitly confirms that they know what they are doing. In this case we must check that the address that the user has given (and the we use to locate the state of the channel) matches the one in the IOU.
gpevnev
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IOU is received its signature covers a channel address. There
are two possible ways to proceed:
this IOU has been received from.
Had we gone with option 1, we would not have this issue.
But we chose option 2, ironically, as an extra precaution: by explicitly
giving the address of the channel “through” which the IOU was received,
the user explicitly confirms that they know what they are doing. In this
case we must check that the address that the user has given (and the we
use to locate the state of the channel) matches the one in the IOU.