Add NGINX_ACCESS_LOG and NGINX_ERROR_LOG

[robsontenorio]

This is my first contribution. Let me know if something can be adjusted.

Targeting release/v3.6

I kept the default current values (/dev/stdout and /dev/stderr). But, honestly I would change it to the Nginx defaults.
Because, it is not useful to have all that logs on the main stdout. But if you don't think so, it is all good to be merged.

Usage

FROM serversideup ...
ENV NGINX_ACCESS_LOG=/var/log/nginx/access.log
ENV NGINX_ERROR_LOG=/var/log/nginx/error.log

[jaydrogers]

Sorry for the hiccup here, but could you try creating a new PR?

I had to move things in GitHub it automatically closed this PR. I don't see where I can update the branch into https://github.com/serversideup/docker-php/tree/280-create-a-frankenphp-variation

It won't let me change it when I press edit.

[jaydrogers]

NVM, I got it. I accidentally deleted the source branch. That's why it closed. I will be reviewing this for 4.0 and will keep you posted 👍

Sorry for the confusion!

[robsontenorio]

@jaydrogers thanks for considering this for v4 ❤️

[jaydrogers]

Thanks for your patience!

I made some updates so this is compatible with our new v4.0 release:

• Release 4.0: Add FrankenPHP & more Laravel optmizations #283

Just a note on not using stdout/stderr

By default, we keep these as stdout/stderr because in containerized environments anything that hits stdout/stderr be handled by the container orchestrator -- giving you a ton of flexibility and centralized control in log management, monitoring, etc

More on that here: https://docs.docker.com/engine/logging/