Skip to content

Added multi selection feature in messages #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Added multi selection feature in messages #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36380a0
Added multi selection feature in messages
mikoldin123 Oct 20, 2025
5809707
Added selection manager to handle button creation and events
mikoldin123 Oct 21, 2025
856de71
Added navigation to info page
mikoldin123 Oct 21, 2025
20b41b3
Updated selected row color
mikoldin123 Oct 21, 2025
4d4c400
Added navigation bar dropdown option
mikoldin123 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Session.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,6 +1173,9 @@
FDFE75B42ABD46B600655640 /* MockUserDefaults.swift in Sources */ = {isa = PBXBuildFile; fileRef = FD83B9D127D59495005E1583 /* MockUserDefaults.swift */; };
FDFE75B52ABD46B700655640 /* MockUserDefaults.swift in Sources */ = {isa = PBXBuildFile; fileRef = FD83B9D127D59495005E1583 /* MockUserDefaults.swift */; };
FDFF9FDF2A787F57005E0628 /* JSONEncoder+Utilities.swift in Sources */ = {isa = PBXBuildFile; fileRef = FDFF9FDE2A787F57005E0628 /* JSONEncoder+Utilities.swift */; };
FE2883272EA70C640097E240 /* MessageSelectionManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = FE2883262EA70C640097E240 /* MessageSelectionManager.swift */; };
FE28832B2EA74D440097E240 /* ManualDropdownPresenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = FE28832A2EA74D440097E240 /* ManualDropdownPresenter.swift */; };
FE28832D2EA74D680097E240 /* CustomMenuView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FE28832C2EA74D680097E240 /* CustomMenuView.swift */; };
FED288F32E4C28CF00C31171 /* AppReviewPromptDialog.swift in Sources */ = {isa = PBXBuildFile; fileRef = FED288F22E4C28CF00C31171 /* AppReviewPromptDialog.swift */; };
FED288F82E4C3BE100C31171 /* AppReviewPromptModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = FED288F72E4C3BE100C31171 /* AppReviewPromptModel.swift */; };
/* End PBXBuildFile section */
Expand Down Expand Up @@ -2467,6 +2470,9 @@
FDFDE129282D056B0098B17F /* MediaZoomAnimationController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MediaZoomAnimationController.swift; sourceTree = "<group>"; };
FDFE75B02ABD2D2400655640 /* _030_MakeBrokenProfileTimestampsNullable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = _030_MakeBrokenProfileTimestampsNullable.swift; sourceTree = "<group>"; };
FDFF9FDE2A787F57005E0628 /* JSONEncoder+Utilities.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "JSONEncoder+Utilities.swift"; sourceTree = "<group>"; };
FE2883262EA70C640097E240 /* MessageSelectionManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MessageSelectionManager.swift; sourceTree = "<group>"; };
FE28832A2EA74D440097E240 /* ManualDropdownPresenter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ManualDropdownPresenter.swift; sourceTree = "<group>"; };
FE28832C2EA74D680097E240 /* CustomMenuView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomMenuView.swift; sourceTree = "<group>"; };
FED288F22E4C28CF00C31171 /* AppReviewPromptDialog.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppReviewPromptDialog.swift; sourceTree = "<group>"; };
FED288F72E4C3BE100C31171 /* AppReviewPromptModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppReviewPromptModel.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */
Expand Down Expand Up @@ -2986,6 +2992,7 @@
B835246C25C38AA20089A44F /* Conversations */ = {
isa = PBXGroup;
children = (
FE2883252EA70C5D0097E240 /* Selection */,
B887C38125C7C79700E11DAE /* Input View */,
B835247725C38D190089A44F /* Message Cells */,
C328252E25CA54F70062D0A7 /* Context Menu */,
Expand Down Expand Up @@ -5300,6 +5307,16 @@
path = Transitions;
sourceTree = "<group>";
};
FE2883252EA70C5D0097E240 /* Selection */ = {
isa = PBXGroup;
children = (
FE28832C2EA74D680097E240 /* CustomMenuView.swift */,
FE28832A2EA74D440097E240 /* ManualDropdownPresenter.swift */,
FE2883262EA70C640097E240 /* MessageSelectionManager.swift */,
);
path = Selection;
sourceTree = "<group>";
};
FED288EF2E4C239800C31171 /* App Review */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -6944,6 +6961,7 @@
7BA37AFD2AEF7C3D002438F8 /* VoiceMessageView_SwiftUI.swift in Sources */,
7B1B52E028580D51006069F2 /* EmojiSkinTonePicker.swift in Sources */,
B849789625D4A2F500D0D0B3 /* LinkPreviewView.swift in Sources */,
FE2883272EA70C640097E240 /* MessageSelectionManager.swift in Sources */,
FD71164428E2CB8A00B47552 /* SessionCell+Accessory.swift in Sources */,
7B1B52DF28580D51006069F2 /* EmojiPickerCollectionView.swift in Sources */,
FDE5219A2E08DBB800061B8E /* ImageLoading+Convenience.swift in Sources */,
Expand Down Expand Up @@ -7061,6 +7079,7 @@
34BECE2E1F7ABCE000D7438D /* GifPickerViewController.swift in Sources */,
9422568C2C23F8C800C0FDBF /* DisplayNameScreen.swift in Sources */,
7B9F71D72853100A006DFE7B /* Emoji+Available.swift in Sources */,
FE28832D2EA74D680097E240 /* CustomMenuView.swift in Sources */,
FD09C5E628260FF9000CE219 /* MediaGalleryViewModel.swift in Sources */,
7B9F71D32852EEE2006DFE7B /* Emoji.swift in Sources */,
C328250F25CA06020062D0A7 /* VoiceMessageView.swift in Sources */,
Expand All @@ -7072,6 +7091,7 @@
FD4B200E283492210034334B /* InsetLockableTableView.swift in Sources */,
FD12A8472AD63C3400EEBA0D /* PagedObservationSource.swift in Sources */,
FDC1BD682CFE6EEB002CDC71 /* DeveloperSettingsViewModel.swift in Sources */,
FE28832B2EA74D440097E240 /* ManualDropdownPresenter.swift in Sources */,
7B0EFDF0275084AA00FFAAE7 /* CallMessageCell.swift in Sources */,
C3AAFFF225AE99710089E6DD /* AppDelegate.swift in Sources */,
FD10AF0C2AF32B9A007709E5 /* SessionListViewModel.swift in Sources */,
Expand Down
54 changes: 54 additions & 0 deletions Session/Conversations/Context Menu/ContextMenuVC+Action.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,14 @@ extension ContextMenuVC {
actionType: .dismiss
) { _ in delegate?.contextMenuDismissed() }
}

static func select(_ cellViewModel: MessageViewModel, _ delegate: ContextMenuActionDelegate?) -> Action {
return Action(
icon: Lucide.image(icon: .circleCheck, size: 24),
title: "select".localized(),
accessibilityLabel: "Select message"
) { completion in delegate?.select(cellViewModel, completion: completion) }
}
}

static func viewModelCanReply(_ cellViewModel: MessageViewModel, using dependencies: Dependencies) -> Bool {
Expand Down Expand Up @@ -202,6 +210,18 @@ extension ContextMenuVC {
case .standardOutgoing, .standardIncoming: break
}

var canSelect: Bool {
guard cellViewModel.variant == .standardIncoming || (
cellViewModel.variant == .standardOutgoing &&
cellViewModel.state != .failed &&
cellViewModel.state != .sending
) else {
return false
}

return true && !forMessageInfoScreen
}

let canRetry: Bool = (
cellViewModel.threadVariant != .legacyGroup &&
cellViewModel.variant == .standardOutgoing && (
Expand Down Expand Up @@ -289,7 +309,9 @@ extension ContextMenuVC {
.compactMap { EmojiWithSkinTones(rawValue: $0) }
}()
let generatedActions: [Action] = [

(canRetry ? Action.retry(cellViewModel, delegate) : nil),
(canSelect ? Action.select(cellViewModel, delegate) : nil),
(viewModelCanReply(cellViewModel, using: dependencies) ? Action.reply(cellViewModel, delegate) : nil),
(canCopy ? Action.copy(cellViewModel, delegate) : nil),
(canSave ? Action.save(cellViewModel, delegate) : nil),
Expand All @@ -310,6 +332,37 @@ extension ContextMenuVC {

return generatedActions.appending(forMessageInfoScreen ? nil : Action.dismiss(delegate))
}


static func navigationActions(
for cellViewModel: MessageViewModel,
in threadViewModel: SessionThreadViewModel,
delegate: ContextMenuActionDelegate?,
using dependencies: Dependencies
) -> [Action]? {
let canDelete: Bool = (MessageViewModel.DeletionBehaviours.deletionActions(
for: [cellViewModel],
with: threadViewModel,
using: dependencies
) != nil)

var showDelete: Bool {
cellViewModel.attachments != nil && canDelete
}

var showCopy: Bool {
cellViewModel.cellType == .textOnlyMessage
}

let generatedActions: [Action] = [
(showCopy ? Action.copy(cellViewModel, delegate) : nil),
(showDelete ? Action.delete(cellViewModel, delegate) : nil),
Action.info(cellViewModel, delegate)
]
.compactMap { $0 }

return generatedActions
}
}

// MARK: - Delegate
Expand All @@ -327,4 +380,5 @@ protocol ContextMenuActionDelegate {
func react(_ cellViewModel: MessageViewModel, with emoji: EmojiWithSkinTones)
func showFullEmojiKeyboard(_ cellViewModel: MessageViewModel)
func contextMenuDismissed()
func select(_ cellViewModel: MessageViewModel, completion: (() -> Void)?)
}
Loading