Fix minimum and maximum version setting #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
previously approved these changes
Mar 31, 2023
sethmlarson
force-pushed
the
fix-min-max-versions
branch
from
23c3697 to
ce70459
Compare
sethmlarson
force-pushed
the
fix-min-max-versions
branch
from
ce70459 to
d963e96
Compare
|
Since the async HTTPX test seems to be the only trouble maker I've decided to skip testing that configuration for tonight. Instead I've created this issue to track testing that config. The synchronous HTTPX client is enough to trigger the error seen in #94. |
davisagli
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94