Add benchmarks for clipperhouse/rate#58
Open
clipperhouse wants to merge 2 commits intosethvargo:mainfrom
Open
Conversation
Signed version
5227903 to
99cba3d
Compare
Author
|
Update to latest version of clipperhouse/rate. Let me know if interested @sethvargo. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Seth! Nice work here. I am working on a new Go rate limiter and would like to add to your benchmarks.
My local run:
If this PR interests you, you’ll want to run your own benchmarks (I didn’t bother with Redis).
And, go.mod has some unrelated changes, feel free to accept or reject. Cheers.