-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs readme, fix bug, and refactor code #44
Open
Virgo-SSS
wants to merge
6
commits into
setnemo:main
Choose a base branch
from
Virgo-SSS:feature/feature_same_validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to prevent DRY (Don't Repeat Yourself) function, use dataProvider and delete duplicate keyrule test
…Virgo-SSS/autogenerated-messages into feature/feature_same_validation
Virgo-SSS
changed the title
docs: update README.md section supported types, add 'same' validation
update docs readme, fix bug, and refactor code
Oct 16, 2023
setnemo
approved these changes
Oct 16, 2023
@Virgo-SSS Hi, thank you for your contribution. Could you check failed actions? |
setnemo
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update according PSR-12 reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Docs :
Fix bug :
Refactor :
Submitting for https://hacktoberfest.com/participation/#pr-mr-details