Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs readme, fix bug, and refactor code #44

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Virgo-SSS
Copy link
Contributor

@Virgo-SSS Virgo-SSS commented Oct 16, 2023

Update Docs :

  • README.md : add 'same' as a supported validation

Fix bug :

  • wrong 'same' validation message
  • the code doesn't following PSR-12 standard code

Refactor :

  • unit test
  • DefaultMessage Trait

Submitting for https://hacktoberfest.com/participation/#pr-mr-details

@Virgo-SSS Virgo-SSS changed the title docs: update README.md section supported types, add 'same' validation update docs readme, fix bug, and refactor code Oct 16, 2023
@setnemo
Copy link
Owner

setnemo commented Oct 16, 2023

@Virgo-SSS Hi, thank you for your contribution. Could you check failed actions?

Copy link
Owner

@setnemo setnemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update according PSR-12 reqs

@Virgo-SSS
Copy link
Contributor Author

Hi, i have been working on it at [fix: fix code following PSR-12 standard] [7688524] commit.
(7688524)

could you try to rerun the actions ?

@setnemo setnemo self-requested a review November 7, 2023 12:10
@setnemo setnemo added the pull_request_target Run gtihub actions label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants