Automatic yellowstone gRPC deduplication for subscribing to multiple streams #494
+501
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update: adjusted metrics logging to include share of first arrival per datasource
andrii-kl
reviewed
Dec 8, 2025
| } | ||
| } | ||
| Update::Transaction(tx) => { | ||
| if tx.block_time.is_none() { |
Contributor
There was a problem hiding this comment.
This only works if the BlockDetails arrive before the transaction. If the transaction arrives first, it will remain without a block_time.
andrii-kl
reviewed
Dec 8, 2025
| _ => {} | ||
| } | ||
|
|
||
| if let Some(slot) = extract_slot(&update) { |
andrii-kl
reviewed
Dec 8, 2025
| } | ||
|
|
||
| pub fn get_datasource_last_slots() -> HashMap<String, u64> { | ||
| DATASOURCE_LAST_SLOTS.read().unwrap().clone() |
Contributor
There was a problem hiding this comment.
Each call creates a full copy of the HashMap.
| slot_time_index: LruCache<u64, i64>, | ||
| } | ||
|
|
||
| static DATASOURCE_LAST_SLOTS: Lazy<RwLock<HashMap<String, u64>>> = |
Contributor
There was a problem hiding this comment.
RwLock may not be the best choice, but this appears to be dead code that isn't used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new: added automatic dedupe for yellowstone gRPC
update: adjusted metrics logging to include share of first arrival per datasource