Change default 2.5D WFS fs driving function #168
Merged
+53
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #146 which introduced a fix for the 2.5D reference scheme in 2.5D as the current default implementation has the problem of possible division by 0. The resulting problems can be seen by running
test_localwfs_vss(1)or by executing the example provided in #146.As the proposed solution of a reference circle includes the point solution, which is currently implemented with
conf.xrefit should be ok to switch the default to this, even if the documentation is not up to date with it and we will have a new referencing scheme in 2.5 anyhow, see #136.@fietew: if you agree with this, please "rebase and merge". If it would include more work, I would propose to postpone it also to the release 2.5.