Init moe support #16
Draft
Init moe support #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
airMeng
commented
Oct 17, 2025
airMeng
commented
- moe scatter and gather update to the latest main
- cutlass based MoE GEMM
airMeng
force-pushed
the
moe
branch
4 times, most recently
from
6589915 to
0004dab
Compare
| } | ||
| }; | ||
|
|
||
| void moe_grouped_mm_nt( |
There was a problem hiding this comment.
From BLAS perspective, this one's actually tt. That might confuse some folks.
Collaborator
Author
There was a problem hiding this comment.
yes I will align with cutlass side later
There was a problem hiding this comment.
Sorry, I wasn't referring to cutlass convention. I meant that the terms nt, tt etc. are BLAS convention.
cutlass uses terms such as K-major, etc. instead.
If A is [M, K] with strides [K, 1], then BLAS still considers it transposed, and uses the notation t for it.
sanchitintel
reviewed
Nov 7, 2025
| using GmemTiledCopyB = XE_2D_U16x16x16_LD_T; | ||
|
|
||
| // Workgroup-level tile | ||
| using TileShape = Shape<_256, _256, _32>; |
There was a problem hiding this comment.
Please consider using a smaller value of Workgroup tile M dimension for decoding. Maybe 8 or 16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.