Skip to content

Conversation

@Hide-on-bushsh
Copy link
Contributor

Motivation

image EPD encoder only adapt npu ## Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Hide-on-bushsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug by ensuring that the correct distributed communication backend is utilized when the system operates on NPU hardware. By conditionally switching from 'nccl' to 'hccl' for NPUs, the change guarantees that distributed operations leverage the appropriate, optimized library, thereby enhancing stability and performance on NPU-enabled systems.

Highlights

  • NPU Backend Selection: The distributed communication backend is now dynamically set to 'hccl' when running on a Neural Processing Unit (NPU) to ensure proper functionality and compatibility. For non-NPU environments, 'nccl' remains the default.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly implements the logic to use hccl as the distributed backend when running on an NPU, falling back to nccl otherwise. This aligns with the bugfix described in the PR title. The is_npu utility function is appropriately imported and utilized for this conditional logic.

Copy link
Collaborator

@ShangmingCai ShangmingCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix lint.

@Hide-on-bushsh
Copy link
Contributor Author

Looks good. Please fix lint.

done

@Hide-on-bushsh
Copy link
Contributor Author

/tag-run-ci-label

@ShangmingCai
Copy link
Collaborator

/tag-and-rerun-ci

@ShangmingCai
Copy link
Collaborator

/rerun-stage unit-test-backend-4-gpu

@github-actions
Copy link
Contributor

✅ Triggered unit-test-backend-4-gpu to run independently (skipping dependencies).

@github-actions
Copy link
Contributor

🔗 View workflow run

@Hide-on-bushsh Hide-on-bushsh changed the title bugfix: hccl should be used instead of nccl on the npu bugfix: nccl adapt --encoder-only on the npu Jan 30, 2026
@Hide-on-bushsh Hide-on-bushsh changed the title bugfix: nccl adapt --encoder-only on the npu bugfix: prioritize init_npu_backend to fix various initialization bugs Feb 3, 2026
@iforgetmyname
Copy link
Collaborator

/rerun-failed-ci

Copy link
Collaborator

@ShangmingCai ShangmingCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this fix is more accurate compared to the previous encoder server fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants