[Fix] data race in req_to_token pool #17850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The chunked prefill requests will free its slot in
req_to_token_pooland get allocated again when preparing for its next prefill batch.As a result, if a prefill batch contains multiple requests and
req_to_token_poolis at capacity. The write for matched kv indices for another request will overwrite the slot of the chunked requests which is being read in forward streamExample
Modifications
alloc(reqs: list[Req])- Now takes request list, setsreq.req_pool_idxdirectly, reuses slot if already set. cc @hnyls2002free()withfree_mamba_cache(req, ...)inHybridReqToTokenPool- Only frees mamba state, not req slot cc @hanming-lu @yizhang2077release_kv_cache()- Now callsfree(req)at end; handles early mamba-only free casefree()inprocess_prefill_chunkandcache_finished_reqAccuracy Tests
Benchmarking and Profiling
Checklist