Skip to content

[AMD] Fix AMD CI install dependencies#18027

Closed
yctseng0211 wants to merge 3 commits intosgl-project:mainfrom
yctseng0211:fix_ci_0131
Closed

[AMD] Fix AMD CI install dependencies#18027
yctseng0211 wants to merge 3 commits intosgl-project:mainfrom
yctseng0211:fix_ci_0131

Conversation

@yctseng0211
Copy link
Collaborator

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@github-actions github-actions bot added the amd label Jan 31, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yctseng0211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with AMD CI installation dependencies by disabling a specific part of the setup process. The change involves commenting out the commands related to the installation of a 'dummy-grok' component, which is intended to streamline or fix the AMD CI pipeline by removing a potentially problematic or no longer required step.

Highlights

  • AMD CI Dependency Script Modification: The installation steps for a 'dummy-grok' component within the AMD CI dependency script (amd_ci_install_dependency.sh) have been commented out. This includes commands for creating a directory, downloading a JSON file, and copying it into the Docker container.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yctseng0211 yctseng0211 added run-ci and removed amd labels Jan 31, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with AMD CI dependency installation by commenting out several lines related to a dummy_grok.json file. While this may fix the immediate problem, a better long-term solution is to remove the code entirely if it's no longer needed. This improves maintainability by preventing dead code from accumulating in the codebase. My review includes a suggestion to this effect.

Comment on lines +126 to +128
# docker exec -w / ci_sglang mkdir -p /dummy-grok
# mkdir -p dummy-grok && wget https://sharkpublic.blob.core.windows.net/sharkpublic/sglang/dummy_grok.json -O dummy-grok/config.json
# docker cp ./dummy-grok ci_sglang:/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If this code is no longer necessary, it's better to remove it completely rather than commenting it out. This improves code clarity and reduces technical debt. Version control will preserve the history if this code needs to be restored in the future.

@yctseng0211 yctseng0211 marked this pull request as ready for review January 31, 2026 08:43
@yctseng0211 yctseng0211 closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant