[AMD] Fix AMD CI install dependencies#18027
[AMD] Fix AMD CI install dependencies#18027yctseng0211 wants to merge 3 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @yctseng0211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with AMD CI installation dependencies by disabling a specific part of the setup process. The change involves commenting out the commands related to the installation of a 'dummy-grok' component, which is intended to streamline or fix the AMD CI pipeline by removing a potentially problematic or no longer required step. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with AMD CI dependency installation by commenting out several lines related to a dummy_grok.json file. While this may fix the immediate problem, a better long-term solution is to remove the code entirely if it's no longer needed. This improves maintainability by preventing dead code from accumulating in the codebase. My review includes a suggestion to this effect.
| # docker exec -w / ci_sglang mkdir -p /dummy-grok | ||
| # mkdir -p dummy-grok && wget https://sharkpublic.blob.core.windows.net/sharkpublic/sglang/dummy_grok.json -O dummy-grok/config.json | ||
| # docker cp ./dummy-grok ci_sglang:/ |
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci