-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Support Markdown/Notebook-Friendly Documentation Export for Downstream Integration #18131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @klhhhhh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation build process by adding a new capability to export Jupyter Notebooks into Markdown format. This change is crucial for enabling more flexible and notebook-friendly documentation for downstream integration, allowing content to be consumed in various formats without requiring notebook execution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Fix issue #18081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new markdown target to the docs/Makefile to export Jupyter notebooks to Markdown files. The implementation is functionally correct and uses parallel for concurrency, which is great.
My review includes a suggestion to simplify the script within the parallel command by using its built-in features and leveraging jupyter nbconvert's options more effectively. This will improve the readability and maintainability of the Makefile.
| NB_SRC="{}"; \ | ||
| REL_DIR=$$(dirname "$$NB_SRC"); \ | ||
| NB_NAME=$$(basename "$$NB_SRC"); \ | ||
| NB_BASE=$${NB_NAME%.ipynb}; \ | ||
| OUT_DIR="$(BUILDDIR)/md/$$REL_DIR"; \ | ||
| mkdir -p "$$OUT_DIR"; \ | ||
| jupyter nbconvert --to markdown "$$NB_SRC" \ | ||
| --output "$$NB_BASE.md" \ | ||
| --output-dir "$$OUT_DIR" \ | ||
| >/dev/null; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script within parallel can be significantly simplified by using GNU Parallel's built-in replacement strings and leveraging jupyter nbconvert's ability to create output directories. This will make the script more concise and idiomatic.
You can replace the current block of shell commands with a single jupyter nbconvert call:
jupyter nbconvert --to markdown "{}" \
--output "{/.}.md" \
--output-dir "$(BUILDDIR)/md/{//}" \
>/dev/null;Here's what the replacement strings do:
{}: The full path to the notebook.{//}: The directory name of the notebook.{/.}: The basename of the notebook without the extension.
The mkdir -p command is also redundant because jupyter nbconvert creates the output directory specified by --output-dir if it doesn't exist.
zhaochenyang20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Documentation Build and Markdown Export WorkflowOverviewThe SGLang documentation pipeline is based on Sphinx and supports rendering Jupyter notebooks ( The key idea is to reuse the existing build directory ( Current Documentation Build Flow1. Notebook Execution (
|
Updated documentation style guidelines and clarified the documentation build process, including the addition of Markdown export and CI execution order.
…am Integration (sgl-project#18131) Co-authored-by: 赵晨阳 <[email protected]>


Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci