Skip to content

[diffusion] refactor: move model_stages into stages folder#18248

Merged
mickqian merged 2 commits intomainfrom
diffusion-refactor
Feb 4, 2026
Merged

[diffusion] refactor: move model_stages into stages folder#18248
mickqian merged 2 commits intomainfrom
diffusion-refactor

Conversation

@mickqian
Copy link
Collaborator

@mickqian mickqian commented Feb 4, 2026

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@mickqian mickqian requested a review from yhyang201 as a code owner February 4, 2026 11:54
@github-actions github-actions bot added the diffusion SGLang Diffusion label Feb 4, 2026
@mickqian
Copy link
Collaborator Author

mickqian commented Feb 4, 2026

/tag-and-rerun-ci

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mickqian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a structural refactoring, reorganizing model-specific stage definitions within the project. The primary goal is to enhance code organization and maintainability by consolidating pipeline-related components into a more intuitive directory structure, making it easier for developers to navigate and understand the codebase.

Highlights

  • Refactor Model Stages: Model-specific stage definitions have been relocated from sglang.multimodal_gen.runtime.models.model_stages to a new, more logical directory: sglang.multimodal_gen.runtime.pipelines_core.stages.model_specific_stages.
  • Updated Import Paths: All affected files, including glm_image.py, mova_pipeline.py, and qwen_image.py, have had their import statements updated to reflect the new locations of the moved stage modules.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/sglang/multimodal_gen/runtime/models/model_stages/glm_image.py
    • Renamed to python/sglang/multimodal_gen/runtime/pipelines_core/stages/model_specific_stages/glm_image.py.
  • python/sglang/multimodal_gen/runtime/models/model_stages/mova.py
    • Renamed to python/sglang/multimodal_gen/runtime/pipelines_core/stages/model_specific_stages/mova.py.
  • python/sglang/multimodal_gen/runtime/models/model_stages/qwen_image_layered.py
    • Renamed to python/sglang/multimodal_gen/runtime/pipelines_core/stages/model_specific_stages/qwen_image_layered.py.
  • python/sglang/multimodal_gen/runtime/pipelines/glm_image.py
    • Updated the import path for GlmImageBeforeDenoisingStage to its new location within pipelines_core/stages/model_specific_stages.
  • python/sglang/multimodal_gen/runtime/pipelines/mova_pipeline.py
    • Updated import paths for MOVADecodingStage, MOVADenoisingStage, MOVALatentPreparationStage, and MOVATimestepPreparationStage to their new pipelines_core/stages/model_specific_stages location.
  • python/sglang/multimodal_gen/runtime/pipelines/qwen_image.py
    • Updated the import path for QwenImageLayeredBeforeDenoisingStage to its new location under pipelines_core/stages/model_specific_stages.
Activity
  • The pull request was opened by mickqian.
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the run-ci label Feb 4, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving model-specific pipeline stages from runtime/models/model_stages to a more appropriate location at runtime/pipelines_core/stages/model_specific_stages. This change improves the organization of the codebase by grouping pipeline stages together, making the project structure more logical and easier to navigate. The import paths have been updated accordingly across the affected pipeline files. The changes are clean, focused, and represent a good improvement to the project's maintainability. I have reviewed the changes and found no issues.

@mickqian mickqian merged commit 36a3e78 into main Feb 4, 2026
151 of 159 checks passed
@mickqian mickqian deleted the diffusion-refactor branch February 4, 2026 16:23
charlesHsuGG pushed a commit to charlesHsuGG/sglang that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant