[diffusion] chore: forbid Chinese characters

[mickqian]

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments or contact authorized users to do so.
   • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
4. After green CI and required approvals, ask Merge Oncalls to merge.

[mickqian]

/tag-and-rerun-ci

[gemini-code-assist]

Summary of Changes

Hello @mickqian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new pre-commit hook to enforce a consistent character set within the sglang codebase, specifically targeting the multimodal_gen components. The primary goal is to prevent the accidental inclusion of Chinese characters in these files, which helps maintain code quality, simplifies internationalization efforts, and ensures compatibility across different systems and tools.

Highlights

• New Pre-Commit Hook: A new pre-commit hook named check-chinese-characters has been added to the .pre-commit-config.yaml.
• Character Enforcement: This hook is designed to forbid the presence of Chinese characters ([一-鿿]) in specified files.
• Targeted Scope: The check specifically applies to files within the python/sglang/multimodal_gen/ directory, excluding the configs/sample/ subdirectory.
• File Types: The hook will scan python, markdown, json, and generic text file types for these characters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .pre-commit-config.yaml
  • Added a new local hook with id: check-chinese-characters.
  • Configured the hook to execute a Python script that uses a regular expression ([一-鿿]) to detect Chinese characters.
  • Set the files pattern to ^python/sglang/multimodal_gen/.* to target relevant files.
  • Added an exclude pattern ^python/sglang/multimodal_gen/configs/sample/ to skip specific configuration files.
  • Specified types_or: [python, markdown, json, text] to apply the check to multiple file formats.

Activity

• The pull request was opened by mickqian.
• A new pre-commit hook was introduced to enforce character set standards.
• The provided PR description template indicates no specific human activity or review comments beyond the initial submission.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a pre-commit hook to prevent Chinese characters in certain files. The implementation uses a complex one-liner Python script. While functional, this approach is difficult to read, debug, and maintain. I've suggested refactoring this into a separate, more readable Python script for better long-term maintainability.

[gemini-code-assist]

This one-liner is quite complex and hard to read and maintain. It would be much better to move this logic into a separate Python script file. This improves readability, makes it easier to debug, and is more aligned with best practices like using with statements for file handling.

For example, you could create a script scripts/check_chinese_chars.py with the following content:

# scripts/check_chinese_chars.py
import sys
import re

CHINESE_CHAR_RE = re.compile(r"[\u4e00-\u9fff]")
exit_code = 0

for filename in sys.argv[1:]:
    try:
        with open(filename, "r", encoding="utf-8", errors="ignore") as f:
            for i, line in enumerate(f, 1):
                if CHINESE_CHAR_RE.search(line):
                    print(f"{filename}:{i}: {line.strip()}")
                    exit_code = 1
    except Exception as e:
        print(f"Error processing file {filename}: {e}", file=sys.stderr)
        exit_code = 1

sys.exit(exit_code)

Then, you can update the entry to simply call this script:

        entry: python3 scripts/check_chinese_chars.py

This change would make the hook's logic much more transparent and maintainable.