fix(navigation-menu): apply active styles via data-[active] #9019
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TadokoroYuki is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Duplicate of #8967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
data-[active]styles tonavigationMenuTriggerStyleso active links are visually highlighted when this style is applied toNavigationMenuLink.Motivation
Radix
NavigationMenuLinksetsdata-activeas a boolean attribute (data-active=""), so selectors likedata-[active=true]won't match. Some users applynavigationMenuTriggerStyle()to links (e.g. header navigation), which makes the active state hard to see.Changes
data-[active]:...styles alongside existingdata-[state=open]:...styles.Testing
Fixes #6914