fix(sidebar): handle active state correctly on menu buttons #9067
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@thisismert is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CSS selector bug in the sidebar where presence-based data-active selectors were causing all sidebar items to appear active, even when the attribute was set to "false". The fix updates these selectors to use value-based checks (data-[active=true]) instead.
- Updated sidebar menu button and sub-button styles to use value-based
data-[active=true]selectors - Consolidated the
font-mediumstyle with other active state styles for better organization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/v4/registry/styles/style-vega.css | Updated .cn-sidebar-menu-button and .cn-sidebar-menu-sub-button classes to use data-[active=true] selectors |
| apps/v4/registry/styles/style-nova.css | Updated .cn-sidebar-menu-button and .cn-sidebar-menu-sub-button classes to use data-[active=true] selectors |
| apps/v4/registry/styles/style-mira.css | Updated .cn-sidebar-menu-button and .cn-sidebar-menu-sub-button classes to use data-[active=true] selectors |
| apps/v4/registry/styles/style-maia.css | Updated .cn-sidebar-menu-button and .cn-sidebar-menu-sub-button classes to use data-[active=true] selectors |
| apps/v4/registry/styles/style-lyra.css | Updated .cn-sidebar-menu-button and .cn-sidebar-menu-sub-button classes to use data-[active=true] selectors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shadcn
added
the
area: roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar styles currently rely on presence-based
data-activeselectors, which apply active styles whenever the attribute exists.Since
data-active="false"still counts as a present attribute, this caused all sidebar items to appear active.This PR updates the sidebar styles to use value-based selectors (
data-[active=true]).