fix(calendar): add ref forwarding to Button component for react-day-picker compatibility #9082
+15
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Calendar component's inability to forward refs to the Button component used in CalendarDayButton. The react-day-picker library requires ref forwarding for proper focus management and keyboard navigation.
Problem
The Base UI Button component was not forwarding refs, causing TypeScript errors when used in the Calendar component:
Solution
Wrapped the Button component with React.forwardRef to properly forward refs to the underlying ButtonPrimitive component.
Changes Made
Before:
After:
Related Issue
Closes #9046
Testing