Add a new section that explains the variable scope problem with for-loop#32
Open
jkwak-work wants to merge 2 commits intoshader-slang:mainfrom
Conversation
jkwak-work
force-pushed
the
variable_declaration_conflict_in_for_loop_when_input_is_hlsl
branch
from
90589ae to
cc8f9d8
Compare
csyonghe
requested changes
Dec 13, 2024
| ``` | ||
|
|
||
| #### Variable scope in `for`-loop follows the old FXC rule | ||
| The older version of HLSL compiler, FXC, had a little different variable scope for the `for`-loop compared to other languages. |
Contributor
There was a problem hiding this comment.
By default, the language is slang so you will never run into this issue. This is only the case if the user explicitly specified -lang hlsl. We should simply advise users to not set input language to HLSL.
Contributor
|
This PR is nearly a year old -- is it still relevant at all? Should it just be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a need to explain the behavior for the variable declared inside of for-loop.
The issue was asked on "Discussion":
shader-slang/slang#5824