fix(demo): Log demo errors to the console #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a "request fails" in the demo, sometimes it is because of an exception elsewhere in the process. This logs those errors to the console so that they can be traced and fixed.
avelad
reviewed
May 14, 2024
| @@ -53,6 +53,7 @@ document.addEventListener('DOMContentLoaded', () => { | |||
| window.results.textContent = | |||
| formatObjectToString(mksa.getConfiguration()); | |||
| } catch (error) { | |||
| console.log(error); | |||
There was a problem hiding this comment.
Wouldn't it be better to use console.error?
There was a problem hiding this comment.
No, IMO. console.error shows a backtrace to the line of the console.error call. Printing an error object, at any log level, shows the backtrace of the error itself. So using console.error on an error object gives you two different backtraces, and it gets confusing, IMO, when you expand the wrong one.
avelad
approved these changes
May 14, 2024
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a "request fails" in the demo, sometimes it is because of an exception elsewhere in the process. This logs those errors to the console so that they can be traced and fixed.