-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Prevent leaked credentials (#8142)
Naive use of google-github-actions/auth and google-github-actions/deploy-appengine can lead to leaked credentials. In particular, uploading static content from the workspace root leads to servable copies of the credentials file written by google-github-actions/auth. This is exactly what the Shaka Player Demo did. Making matters worse, google-github-actions/auth logs credential filenames for all to see. All uploaded credentials were expired before I uploaded this PR. This fixes the leak by installing a gcloudignore file which prevents the credentials from being uploaded.
- Loading branch information
1 parent
c080f85
commit 3a47bd1
Showing
3 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,3 +54,4 @@ runs: | |
run: | | ||
mv app-engine/shaka-player-demo/* . | ||
rm README.md | ||
mv app-engine/gcloudignore .gcloudignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# Defaults you get without an explicit .gcloudignore file | ||
.git | ||
.gitignore | ||
.gcloudignore | ||
|
||
# Ignore generated credentials from google-github-actions/auth | ||
gha-creds-*.json |