Skip to content

Commit

Permalink
chore: Remove older version of Chrome in layout tests (#8208)
Browse files Browse the repository at this point in the history
The current version is 133, so it is safe to make this change.
  • Loading branch information
avelad committed Mar 5, 2025
1 parent 4b28c55 commit 57ca5da
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions test/test/util/layout_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests {
// We only trust Safari for native text layout tests if explicitly flagged.
// We only do this in our lab, where we control device a11y settings that
// impact these tests heavily.
if (shaka.util.Platform.safariVersion() &&
if (shaka.util.Platform.isApple() &&
!getClientArg('trustSafariNativeTextLayout')) {
return false;
}
Expand All @@ -188,13 +188,6 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests {
return false;
}

// Due to updates in the rendering and/or default styles in Chrome, the
// screenshots for native rendering only match in Chrome 106+.
const chromeVersion = shaka.util.Platform.chromeVersion();
if (chromeVersion && chromeVersion < 106) {
return false;
}

return true;
}

Expand Down

0 comments on commit 57ca5da

Please sign in to comment.