Theory 2: event.preventDefault()

shaka-project · Feb 26, 2025 · 67d9d04 · 67d9d04
1 parent dadd39a
commit 67d9d04
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/lib/offline/indexeddb/db_operation.js b/lib/offline/indexeddb/db_operation.js
@@ -30,11 +30,9 @@ shaka.offline.indexeddb.DBOperation = class {
     // |event.preventDefault()| is used on all non-successful callbacks to
     // prevent Firefox from surfacing the error on the main thread.
     transaction.onabort = (event) => {
-      event.preventDefault();
       this.promise_.reject();
     };
     transaction.onerror = (event) => {
-      event.preventDefault();
       this.promise_.reject();
     };
     transaction.oncomplete = (event) => {

diff --git a/lib/offline/indexeddb/storage_mechanism.js b/lib/offline/indexeddb/storage_mechanism.js
@@ -104,9 +104,6 @@ shaka.offline.indexeddb.StorageMechanism = class {
           shaka.util.Error.Code.INDEXED_DB_ERROR,
           open.error));
       timeOutTimer.stop();
-
-      // Firefox will raise an error on the main thread unless we stop it here.
-      event.preventDefault();
     };
 
     return p;
@@ -350,9 +347,6 @@ shaka.offline.indexeddb.StorageMechanism = class {
           shaka.util.Error.Category.STORAGE,
           shaka.util.Error.Code.INDEXED_DB_ERROR,
           del.error));
-
-      // Firefox will raise an error on the main thread unless we stop it here.
-      event.preventDefault();
     };
 
     return p;

diff --git a/test/test/util/canned_idb.js b/test/test/util/canned_idb.js
@@ -176,7 +176,6 @@ shaka.test.CannedIDB = class {
       };
 
       request.onerror = (event) => {
-        event.preventDefault();
         reject(request.error);
       };
     });
@@ -238,7 +237,6 @@ shaka.test.CannedIDB = class {
       };
 
       request.onerror = (event) => {
-        event.preventDefault();
         resolve();
       };
     });
@@ -300,7 +298,6 @@ shaka.test.CannedIDB = class {
       };
 
       request.onerror = (event) => {
-        event.preventDefault();
         reject(request.error);
       };
     });
@@ -341,7 +338,6 @@ shaka.test.CannedIDB = class {
 
       transaction.onerror = (event) => {
         reject(event.error);
-        event.preventDefault();
       };
     });
   }