Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebOS): Do not preload DRM on legacy EME #8083

Merged
merged 9 commits into from
Feb 17, 2025
Merged

fix(WebOS): Do not preload DRM on legacy EME #8083

merged 9 commits into from
Feb 17, 2025

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Feb 14, 2025 •
edited
Loading

Fixes #7770
Webkit DRM heavily relies on video element, so it needs to be provided in proper order to avoid any issues.

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: WebOS Issues affecting WebOS labels Feb 14, 2025
@tykus160
Copy link
Member Author

@subhanahmed047 @koenoe if you are able to test this PR on your devices, that would be great! I have confirmation it works on TV we have for tests, but more data is better data.

avelad
avelad reviewed Feb 14, 2025
View reviewed changes
tykus160 and others added 2 commits February 14, 2025 13:21
@tykus160 @avelad
Update lib/player.js
ec6b4a3 
Co-authored-by: Álvaro Velad Galván <[email protected]>
@tykus160
2 mutexes
327bea6
avelad
avelad reviewed Feb 14, 2025
View reviewed changes
avelad
avelad reviewed Feb 14, 2025
View reviewed changes
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 92.59%

@subhanahmed047
Copy link
Contributor

@subhanahmed047 @koenoe if you are able to test this PR on your devices, that would be great! I have confirmation it works on TV we have for tests, but more data is better data.

Thanks for the PR. I'll give it a go as a first thing next week.

@tykus160 tykus160 added the component: PlayReady The issue involves the PlayReady DRM label Feb 14, 2025
@avelad
Copy link
Member

avelad commented Feb 17, 2025 •
edited
Loading

@subhanahmed047 @koenoe if you are able to test this PR on your devices, that would be great! I have confirmation it works on TV we have for tests, but more data is better data.

Thanks for the PR. I'll give it a go as a first thing next week.

@subhanahmed047 Do you have any update? Thanks!

@tykus160 tykus160 merged commit 477bbbf into shaka-project:main Feb 17, 2025
17 of 18 checks passed
@tykus160 tykus160 deleted the wt-webkit-preload-upstream branch February 17, 2025 14:50
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2025
Open
tykus160 added a commit that referenced this pull request Feb 17, 2025
@tykus160 @avelad
fix(WebOS): Do not preload DRM on legacy EME (#8083)
79f5151 
Fixes #7770 
Webkit DRM heavily relies on video element, so it needs to be provided
in proper order to avoid any issues.

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2025
Merged
tykus160 added a commit that referenced this pull request Feb 17, 2025
@tykus160 @avelad
fix(WebOS): Do not preload DRM on legacy EME (#8083)
d30533f 
Fixes #7770 
Webkit DRM heavily relies on video element, so it needs to be provided
in proper order to avoid any issues.

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2025
Merged
@koenoe
Copy link
Contributor

koenoe commented Feb 19, 2025

@subhanahmed047 @koenoe if you are able to test this PR on your devices, that would be great! I have confirmation it works on TV we have for tests, but more data is better data.

Sorry for the late reply! I've just tested v4.13.3 and I can confirm it works perfectly fine again on my WebOS 3 device (B6, 2016 model).

@subhanahmed047
Copy link
Contributor

Please see my comment here #7770 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelad avelad avelad approved these changes

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: PlayReady The issue involves the PlayReady DRM platform: WebOS Issues affecting WebOS priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
6 participants
@tykus160 @shaka-bot @subhanahmed047 @avelad @koenoe @theodab