refactor(bbb): Work in progress on BigPlayButton customization in Shaka Player (#8045) #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chafroudtarek
changed the title
chafroudtarek
changed the title
avelad
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Please, we are trying to remain alphabetical order
There was a problem hiding this comment.
I'm not sure we want to add this as is, I think it should be more customizable. @tykus160 any opinion?
There was a problem hiding this comment.
Any suggestions to take into consideration ?
| @@ -106,7 +106,7 @@ | |||
| "build": "python build/all.py", | |||
| "prepack": "clean-package", | |||
| "postpack": "clean-package restore", | |||
| "prepublishOnly": "python build/checkversion.py && python build/all.py --force" | |||
| "prepublishOnly": "python3 build/all.py --force" | |||
There was a problem hiding this comment.
Just creating this PR to inform that work is in progress. Still working on it, and I'll update it soon.
|
Incremental code coverage: No instrumented code was changed. |
|
What is "BigBlueButton"? Can you help me understand more about what you're trying accomplish here? |
chafroudtarek
changed the title
|
Sorry by mistake i mean bigPlaybutton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP #8045 🚧
Work in Progress
I'm currently working on refactoring the customization logic in Shaka Player to improve BigBlueButton handling.