-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config to allow reset MSE on cross boundary #8156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/reset-mse
…nto feature/reset-mse
…ategy to NEVER when originally set to PLAIN_TO_ENCRYPTED
Incremental code coverage: 96.02% |
avelad
requested changes
Feb 26, 2025
tykus160
reviewed
Feb 28, 2025
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
avelad
approved these changes
Mar 5, 2025
tykus160
reviewed
Mar 5, 2025
Co-authored-by: Wojciech Tyczyński <[email protected]>
tykus160
approved these changes
Mar 5, 2025
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's devices out there that are not compliant with the MSE spec. Such as halting MSE when a secondary init segment is appended (webOS 3), or failing to transition from a plain to encrypted init segment (Tizen 2017). While we initially prefer content workarounds, it's a time consuming and trial & error process. For some devices it might not be worth investing time into finding a proper workaround due to low usage. We're giving people an alternative by resetting MSE when needed (configurable). dash.js offers somewhat similar behavior here, where MSE is reset before applying an encrypted init segment.
This PR introduces
crossBoundaryStrategy
inStreamingConfiguration
. It can be configured as following:Each initSegmentReference now holds an
encrypted
andboundaryEnd
value. When configured with a different value than KEEP,StreamingEngine
will be instructed to fetch and append segment references up until the boundary of the currently applied init segment.We detect whether we're at a boundary in a few ways:
waiting
event, this'll indicate that we do not have enough buffer to advance. If we're pretty close to the boundary, we assume we're at the boundary.The implementation relies on the added properties in the init segment reference, and the concept of a "Period" is avoided in StreamingEngine to ensure it's compatible with HLS too.