Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove older version of Chrome in layout tests #8208

Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore: Remove older version of Chrome in layout tests #8208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions test/test/util/layout_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests {
// We only trust Safari for native text layout tests if explicitly flagged.
// We only do this in our lab, where we control device a11y settings that
// impact these tests heavily.
if (shaka.util.Platform.safariVersion() &&
if (shaka.util.Platform.isApple() &&
!getClientArg('trustSafariNativeTextLayout')) {
return false;
}
Expand All @@ -188,13 +188,6 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests {
return false;
}

// Due to updates in the rendering and/or default styles in Chrome, the
// screenshots for native rendering only match in Chrome 106+.
const chromeVersion = shaka.util.Platform.chromeVersion();
if (chromeVersion && chromeVersion < 106) {
return false;
}

return true;
}

Expand Down