-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Text font scaling customisation ability #8215
feat: Text font scaling customisation ability #8215
Conversation
Will need to use these in UI text displayer
Use the CSS vars - need to add/update UT
@tykus160 I think that custom variables are not supported on Tizen 3 and WebOS 3, https://caniuse.com/css-variables , can you confirm? |
undo bg color
@avelad they don't, similar on older WebOSes. |
@david-hm-morgan Then you need use something like https://stackoverflow.com/questions/38012009/how-to-feature-detect-for-css-custom-properties to keep the compatibility with old browsers (FYI @tykus160 ) |
Incremental code coverage: 100.00% |
@shaka-bot test ce |
@avelad: Lab tests started with arguments:
|
The next tests are failing on Tizen:
|
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
@david-hm-morgan Can you add a brief documentation about it in |
@david-hm-morgan I'll wait for the tests to pass and merge it. |
With reference to #8025, this is a partial proposal to see if this style of extensible customisation could be favourable to the shaka-player community:
Proposal for some accessibility options whereby an App builder can customise subtitle/caption size, with the potential of an App offering accessibility options for text size.
This style could be used for other text styling attributes in a similar way, but this is just the first step.