Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary code #8220

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 6, 2025

No description provided.

@avelad avelad added the type: code health A code health issue label Mar 6, 2025
@avelad avelad added this to the v4.14 milestone Mar 6, 2025
@tykus160
Copy link
Member

tykus160 commented Mar 6, 2025

Why is this checked on unload?

@avelad
Copy link
Member Author

avelad commented Mar 6, 2025

Why is this checked on unload?

Actually this is already checked at the end of the method, so it is not necessary.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 84c73f8 into shaka-project:main Mar 6, 2025
21 checks passed
@avelad avelad deleted the useless-code branch March 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants