add support for debouncing leading event #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I wish how events got debounced/throttled was handled by the user as I don't want to rebuild those existing libs. But I can't think of a better way to handle it atm so merging this option. Thanks! |
shama
added a commit
that referenced
this pull request
Mar 23, 2015
add support for debouncing leading event
|
Please provide some documentation for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debounceDelayonly applies to subsequent events, not the initial event, which is always immediately fired. In the case that you want to wait for completion of initial activity on a file (e.g. sequential auto-saves in an editor), it's beneficial to debounce the leading event. This patch introducesdebounceLeadingwhich does just that - the leading event will not be fired immediately, but at the end of the debounce timeout.Related issue is: #142
Debouncing the leading event (essentially forcing trailing event emission) coincidentally solve the above problem as well, however there is probably a more general way to solve both issues (see Underscore semantics of debounce and throttle with leading/trailing).
This patch has not been tested on master, but identical patch passes (existing) tests on 0.5.1.