Add device-aware CLI, devices command, completion scripts, and connect wait/retry#159
Draft
Add device-aware CLI, devices command, completion scripts, and connect wait/retry#159
devices command, completion scripts, and connect wait/retry#159Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
connectoptionally wait for an SSID to appear and retry until timeout so non-interactive scripts can robustly connect to networks that appear shortly after invocation.Description
--deviceoption (inOptions) and callconfigureBackendDevice()from each command handler to apply the selected device viaBackend.SetDevicebefore operations.Devicemodel and two methods:ListDevices() ([]Device, error)andSetDevice(name string) errorinwifi/backend.go, and implement them inwifi/networkmanager,wifi/iwd,wifi/darwin, andwifi/mock.wifitui devices(runDevices) that by default prints stable, line-separated device names and supports--jsonto emit richer metadata such asname,type,state,backend, and optionaldetails.wifitui completion <bash|zsh|fish>) and completed scripts that dynamically source--devicevalues fromwifitui devicesand SSID suggestions forconnectfromwifitui list --all --scan.--retryparsing (DURATION[:INTERVAL]) and--waitto enable "require visible" semantics soconnectwill rescan and retry until the SSID appears or timeout; updatedrunConnect/attemptConnectto emit visibility-specific retry messages.ListDevices/SetDevicefor deterministic tests, and adjust platform backends to enumerate/select devices where applicable.main.go/cli.go) and add new/changed tests for CLI parsing, device routing, device command behavior, and connect retry/wait semantics incli_test.goandwifi/mock/mock_test.go, and document usage examples inREADME.md.Testing
go test ./...and all tests passed successfully.cli_test.go) and mock backend device tests (wifi/mock/mock_test.go) and exercised connect retry/wait behavior with simulated backends.devicesandconnect --waitflows in tests (captured by the automated tests above).Codex Task