fix: don't handle publicPath when it is set to auto #308
Conversation
|
@shellscape Thanks for your plugin. It helps me a lot. I have submitted a pr to resolve an issue. If you have any suggestions for modifications, please let me know. |
|
I am also interested in this fix so I tried to resolve the CI issues so that this could be rebased and tested: |
Thanks for you reply. I also noticed the CI failure. What changes do you think are needed for this PR? |
I have not other feedback. Once the CI fixes are merged, this can be rebase to see if all tests pass. |
I will rebase the main branch after 309 was merged. |
shellscape
force-pushed
the
master
branch
3 times, most recently
from
38f9528 to
323af06
Compare
|
Major updates to the repo. Please rebase and check that CI is passing. |
Done. |
…\n\n- publicPath 'auto' + basePath still prefixes manifest keys\n- publicPath 'auto' + plugin publicPath override applies to values\n\nRefs #307
* fix: ignore webpack `publicPath: 'auto'` when generating manifest paths\n\nTreat 'auto' as runtime-resolved publicPath so we don’t serialize it into the manifest. Adds a unit test covering the behavior.\n\nRefs #307 * test: port two 'publicPath: auto' cases from #308 (credit @chouchouji)\n\n- publicPath 'auto' + basePath still prefixes manifest keys\n- publicPath 'auto' + plugin publicPath override applies to values\n\nRefs #307 --------- Co-authored-by: CharlieHelps <[email protected]>
|
Thanks for that. We had a bit of a race between Charlie and you and #312 was merged. Appreciate the PR and your work on it. |
3 participants
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
close #307