Shopping Cart with Js & Python #6
Conversation
| import json | ||
| import os | ||
| from urllib.parse import urlparse | ||
| import redis |
There was a problem hiding this comment.
import modules should be in alphabetic order.
and import multiple modules in one line from the parent module.
like, from werkzeug.routing import Map, Rule
| error = None | ||
| with open('/home/vivek/Desktop/Shopping Site/item_list.json') as f: | ||
| data=json.load(f) | ||
| return self.render_template("homepage.html", error=error, items=data) |
There was a problem hiding this comment.
use a relative path instead of an absolute path.
also, it will raise an error when you don't have data.
try to declare an empty list of data.
| filter = input.value.toUpperCase(); | ||
| ul = document.getElementById("myProducts"); | ||
| li = ul.getElementsByTagName("li"); | ||
| for (i = 0; i < li.length; i++) { |
There was a problem hiding this comment.
use native method instead of for loop.
| @@ -0,0 +1,63 @@ | |||
| var cart = []; | |||
There was a problem hiding this comment.
use ES6 standards to declare the variables.
| </head> | ||
| <div> | ||
| {% block body %}{% endblock %} | ||
| </div> No newline at end of file |
There was a problem hiding this comment.
add a blank newline at the end of each file.
| app = ShoppingSite({ | ||
| 'redis_host': redis_host, | ||
| 'redis_port': redis_port | ||
| }) |
There was a problem hiding this comment.
app = ShoppingSite({
'redis_host': redis_host,
'redis_port': redis_port
})
| return app | ||
|
|
||
| if __name__ == "__main__": | ||
| from werkzeug.serving import run_simple |
There was a problem hiding this comment.
import should be placed at the top
| @@ -0,0 +1,63 @@ | |||
| var cart = []; | |||
| $(function () { | |||
|
don't leave extra spaces and do proper indentations. |
vpt-odoo
force-pushed
the
master-trainee-vpt
branch
from
9eb0fd4 to
0562c7b
Compare
No description provided.