Exclude RoleBinding from sample-strategies.yaml #1823
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/cleanup
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/XS
qu1queee
requested review from
qu1queee
and removed request for
apoorvajagtap and
karanibm6
Signed-off-by: Sascha Schwarze <[email protected]>
SaschaSchwarze0
force-pushed
the
sascha-exclude-rolebinding
branch
from
6db4646 to
9fbb7a3
Compare
|
Rebased |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For the multiarch buildstrategy, https://github.com/shipwright-io/build/tree/main/samples/v1beta1/buildstrategy/multiarch-native-buildah, we are delivering also a ClusterRole and RoleBindings so that the running build has the necessary permissions to manage Jobs and Pods in the cluster.
As described in https://github.com/shipwright-io/build/blob/main/docs/buildstrategies.md#installing-multi-arch-native-buildah-strategy, the RoleBinding must be installed in the namespace(s) where the build strategy will be used. As we cannot know which namespaces those are, we should not include this file in our sample-strategies.yaml.
This PR excludes it like we already also exclude our sample namespaces build strategies.
Submitter Checklist
Release Notes