-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #4710 #4793
base: develop
Are you sure you want to change the base?
fix #4710 #4793
Conversation
if (iv.value) | ||
{ | ||
iv.value->build_gradient_parameter_dictionary(dict); | ||
iv.value.reset(); // need to reset it otherwise iv should be created after each iter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
The only thing, might be nitpicking, would be to auto&& iso auto& in the loops.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
let's keep it alive :) |
No description provided.