Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4710 #4793

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix #4710 #4793

wants to merge 1 commit into from

Conversation

vigsterkr
Copy link
Member

No description provided.

@vigsterkr vigsterkr mentioned this pull request Nov 9, 2019
if (iv.value)
{
iv.value->build_gradient_parameter_dictionary(dict);
iv.value.reset(); // need to reset it otherwise iv should be created after each iter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@iglesias iglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
The only thing, might be nitpicking, would be to auto&& iso auto& in the loops.

@stale
Copy link

stale bot commented May 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 14, 2020
@karlnapf
Copy link
Member

let's keep it alive :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants