SG-38306 Remove Python 2 - Part 10 - SSL #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
changed the title
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal
branch
from
22e8204 to
c96c047
Compare
|
It would be great to see this merged |
|
What is the oldest version of python that is officially supported by this API? |
Contributor
Author
The oldest supported Python version is 3.9.
We are working on it but it is not done yet. It will take us a few more month to finish and merge it. |
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal
branch
from
8c8a8fa to
6492b21
Compare
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal
branch
from
6492b21 to
413afc6
Compare
julien-lang
changed the title
This was referenced Jul 16, 2025
Merged
julien-lang
force-pushed
the
SG-38306-python2-removal-six
branch
from
4961679 to
9a131fa
Compare
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal
branch
from
413afc6 to
74a0494
Compare
julien-lang
commented
Jul 17, 2025
julien-lang
commented
Jul 18, 2025
Comment on lines
-3846
to
-3850
| # This is the exact same block as the "except Exception" bellow. | ||
| # We need to do it here because the next except will match it | ||
| # otherwise and will not re-attempt. | ||
| # When we drop support of Python 2 and we will probably drop the | ||
| # next except, we might want to remove this except too. |
Contributor
Author
There was a problem hiding this comment.
This is not accurate anymore after #379. So we remove the comment but keep the block.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Python 2 support by simplifying SSL handling, eliminating the SSL validation fallback mechanism and custom CA store implementation that was needed for older Python versions. This is part of a series of PRs modernizing the codebase for Python 3 only.
- Removes the global
NO_SSL_VALIDATIONflag and related SSL validation fallback logic - Simplifies HTTPS handler to use modern Python 3 SSL context creation
- Updates user agent strings to remove SSL validation status indicators
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shotgun_api3/shotgun.py | Removes SSL validation fallback logic, simplifies HTTPS handler, updates user agent generation |
| tests/test_client.py | Updates test assertions to match new user agent format without SSL validation status |
| tests/test_api.py | Removes tests for SHA-2 SSL error handling and validation fallback behavior |
| docs/reference.rst | Removes documentation reference to NO_SSL_VALIDATION constant |
| docs/advanced/iron_python.rst | Moves SSL-related workaround documentation to legacy section |
eduardoChaucaGallegos
previously approved these changes
Jul 18, 2025
eduardoChaucaGallegos
dismissed stale reviews from carlos-villavicencio-adsk and themself
The base branch was changed.
eduardoChaucaGallegos
approved these changes
Sep 10, 2025
julien-lang
added a commit
that referenced
this pull request
Oct 15, 2025
Should have been removed in #372
julien-lang
added a commit
that referenced
this pull request
Oct 16, 2025
* Renove unused CACertsHTTPSConnection class Should have been removed in #372 * Update shotgun_api3/shotgun.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes SSL code handling edge cases that were only accurate in Python 2.
This is part of a series of PRs modernizing the codebase for Python 3 only.
NO_SSL_VALIDATIONflag and related SSL validation fallback logicPR orders