SG-40026 Fixup super method should not pass self as first argument #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect usage of super() in CACertsHTTPSConnection where self was being passed explicitly, which could lead to incorrect method resolution or runtime errors.
- Remove erroneous self argument from super().init call
- Remove erroneous self argument from super().connect call
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
carlos-villavicencio-adsk
approved these changes
Oct 1, 2025
eduardoChaucaGallegos
approved these changes
Oct 6, 2025
Contributor
Author
|
Replaced by #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of #394 since the PR could not be merged as-is due to recent changes in the repo.
The scope of this PR is exactly the same as #394: Fix misused super in
CACertsHTTPSConnection.Closes #394